Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752930AbbGFOU2 (ORCPT ); Mon, 6 Jul 2015 10:20:28 -0400 Received: from mail-wi0-f174.google.com ([209.85.212.174]:36450 "EHLO mail-wi0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751427AbbGFOUY convert rfc822-to-8bit (ORCPT ); Mon, 6 Jul 2015 10:20:24 -0400 Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2102\)) Subject: Re: [PATCH 0/3] VME bus error handling overhaul From: Dmitry Kalinkin In-Reply-To: <559A7533.8000408@ge.com> Date: Mon, 6 Jul 2015 17:20:20 +0300 Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, Manohar Vanga , Greg Kroah-Hartman , Igor Alekseev Content-Transfer-Encoding: 8BIT Message-Id: References: <1435846266-26958-1-git-send-email-dmitry.kalinkin@gmail.com> <559A7533.8000408@ge.com> To: Martyn Welch X-Mailer: Apple Mail (2.2102) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2550 Lines: 52 Hi Martyn, > On 06 Jul 2015, at 15:31, Martyn Welch wrote: > > These are looking good to me. Thank you for finding time to look at this and the others. > > You mention error handling in relation to vme_master_mmap, am I right in thinking patch 3 avoids errors being recorded when triggered by an mmap access (so as not to appear as a spurious error on a later access)? Yes, this is covered as well. > > I think it would be worth at least logging errors to the kernel log should they be generated and not be handled by a error handler, so someone using mmap gets at least some form of notification that their accesses are resulting on bus errors. What do you think? Yes. I agree with you. Bus error handler could print a message when an error doesn?t trigger any of the registered handlers. What would be really useful, is if we could dispatch such errors to the userspace in a more direct way. Not sure how, though. Cheers, Dmitry > > > On 02/07/15 15:11, Dmitry Kalinkin wrote: >> This moves tsi148 error handling into VME subsystem so it can be shared with >> the other bridge driver. Then there is a change to close a fixme on separating >> errors by address space. And finally a fix for memory leak problem that was >> introduced with support of mmap's. >> >> The next logical step in this direction would be to add error handling support >> to ca91cx42 and make it unconditional for tsi148. It also makes much sense to >> add synchronization to error-related list operations (spinlocks, rcu). >> >> Dmitry Kalinkin (3): >> vme: move tsi148 error handling into VME subsystem >> vme: include address space in error filtering >> vme: change bus error handling scheme >> >> drivers/vme/bridges/vme_ca91cx42.c | 3 +- >> drivers/vme/bridges/vme_tsi148.c | 170 ++++++++++--------------------------- >> drivers/vme/vme.c | 83 ++++++++++++++++++ >> drivers/vme/vme_bridge.h | 21 +++-- >> 4 files changed, 147 insertions(+), 130 deletions(-) >> > > -- > Martyn Welch (Lead Software Engineer) | Registered in England and Wales > GE Intelligent Platforms | (3828642) at 100 Barbirolli Square > T +44(0)1327322748 | Manchester, M2 3AB > E martyn.welch@ge.com | VAT:GB 927559189 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/