Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754661AbbGFQMN (ORCPT ); Mon, 6 Jul 2015 12:12:13 -0400 Received: from mx0a-00176a03.pphosted.com ([67.231.149.52]:37953 "EHLO mx0a-00176a03.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753115AbbGFQML (ORCPT ); Mon, 6 Jul 2015 12:12:11 -0400 X-Greylist: delayed 4902 seconds by postgrey-1.27 at vger.kernel.org; Mon, 06 Jul 2015 12:12:11 EDT Message-ID: <559A95A4.9070102@ge.com> Date: Mon, 6 Jul 2015 15:50:12 +0100 From: Martyn Welch User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Dmitry Kalinkin , , CC: Manohar Vanga , Greg Kroah-Hartman Subject: Re: [PATCH] vme: print unhandled VME access errors References: <559A7533.8000408@ge.com> <1436193835-20154-1-git-send-email-dmitry.kalinkin@gmail.com> In-Reply-To: <1436193835-20154-1-git-send-email-dmitry.kalinkin@gmail.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [3.159.212.191] X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2015-07-06_07:,, signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1506180000 definitions=main-1507060229 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1730 Lines: 51 That's the ticket :-) On 06/07/15 15:43, Dmitry Kalinkin wrote: > This will enable error messages for accesses done through mmap. > > Signed-off-by: Dmitry Kalinkin > --- > This depends on '[PATCH 0/3] VME bus error handling overhaul' patchset. > --- > drivers/vme/vme.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/vme/vme.c b/drivers/vme/vme.c > index 7a10d92..72924b0 100644 > --- a/drivers/vme/vme.c > +++ b/drivers/vme/vme.c > @@ -1028,6 +1028,7 @@ void vme_bus_error_handler(struct vme_bridge *bridge, > { > struct list_head *handler_pos = NULL; > struct vme_error_handler *handler; > + int handler_triggered = 0; > u32 aspace = vme_get_aspace(am); > > list_for_each(handler_pos, &bridge->vme_error_handlers) { > @@ -1040,8 +1041,14 @@ void vme_bus_error_handler(struct vme_bridge *bridge, > handler->first_error = address; > if (handler->num_errors != UINT_MAX) > handler->num_errors++; > + handler_triggered = 1; > } > } > + > + if (!handler_triggered) > + dev_err(bridge->parent, > + "Unhandled VME access error at address 0x%llx\n", > + address); > } > EXPORT_SYMBOL(vme_bus_error_handler); > > -- Martyn Welch (Lead Software Engineer) | Registered in England and Wales GE Intelligent Platforms | (3828642) at 100 Barbirolli Square T +44(0)1327322748 | Manchester, M2 3AB E martyn.welch@ge.com | VAT:GB 927559189 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/