Date: Mon, 6 Jul 2015 16:52:51 +0200
From: Peter Zijlstra <peterz@infradead.org>
To: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org, mingo@kernel.org, laijs@cn.fujitsu.com,
        dipankar@in.ibm.com, akpm@linux-foundation.org,
        mathieu.desnoyers@efficios.com, josh@joshtriplett.org,
        tglx@linutronix.de, rostedt@goodmis.org, dhowells@redhat.com,
        edumazet@google.com, dvhart@linux.intel.com, fweisbec@gmail.com,
        oleg@redhat.com, bobby.prani@gmail.com
Subject: Re: [PATCH RFC tip/core/rcu 2/5] rcu: Short-circuit normal GPs via
 expedited GPs
Message-ID: <20150706145251.GK19282@twins.programming.kicks-ass.net>
References: <1435700910-9104-1-git-send-email-paulmck@linux.vnet.ibm.com>
 <1435700910-9104-2-git-send-email-paulmck@linux.vnet.ibm.com>
 <20150701100521.GP19282@twins.programming.kicks-ass.net>
 <20150701134143.GY3717@linux.vnet.ibm.com>
 <20150701134806.GF25159@twins.programming.kicks-ass.net>
 <20150701140313.GD3717@linux.vnet.ibm.com>
 <20150702120329.GO3644@twins.programming.kicks-ass.net>
 <20150702140617.GG3717@linux.vnet.ibm.com>
 <20150702164816.GB19282@twins.programming.kicks-ass.net>
 <20150702193545.GQ3717@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150702193545.GQ3717@linux.vnet.ibm.com>
User-Agent: Mutt/1.5.21 (2012-12-30)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 927
Lines: 21

On Thu, Jul 02, 2015 at 12:35:45PM -0700, Paul E. McKenney wrote:
> OK, how about this, then?

> rcu: Rename RCU_GP_DONE_FQS to RCU_GP_DOING_FQS
> 
> The grace-period kthread sleeps waiting to do a force-quiescent-state
> scan, and when awakened sets rsp->gp_state to RCU_GP_DONE_FQS.
> However, this is confusing because the kthread has not done the
> force-quiescent-state, but is instead just starting to do it.  This commit
> therefore renames RCU_GP_DONE_FQS to RCU_GP_DOING_FQS in order to make
> things a bit easier on reviewers.
> 
> Reported-by: Peter Zijlstra <peterz@infradead.org>
> Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>

Much better, thanks! :-)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/