Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753792AbbGFPaw (ORCPT ); Mon, 6 Jul 2015 11:30:52 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:47382 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752581AbbGFPas convert rfc822-to-8bit (ORCPT ); Mon, 6 Jul 2015 11:30:48 -0400 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: Documentation: rpcrdma: Merge svcrdma and xprtrdma modules into one From: Chuck Lever In-Reply-To: Date: Mon, 6 Jul 2015 11:30:26 -0400 Cc: "J. Bruce Fields" , Paul Bolle , Andreas Ruprecht , hengelein Stefan , Trond Myklebust , anna.schumaker@netapp.com, davem@davemloft.net, linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8BIT Message-Id: <2BDBB9B7-9BF0-4480-B1EC-908346C0E40F@oracle.com> References: To: Valentin Rothberg X-Mailer: Apple Mail (2.1878.6) X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1556 Lines: 49 Hi Valentin- On Jul 6, 2015, at 3:36 AM, Valentin Rothberg wrote: > On Mon, Jun 22, 2015 at 9:08 AM, Valentin Rothberg > wrote: >> Hi Chuck, >> >> your commit ffe1f0df5862 ("rpcrdma: Merge svcrdma and xprtrdma modules >> into one") has shown up in linux next-20150620. The commit merges >> SUNRPC_XPRT_RDMA_CLIENT and SUNRPC_XPRT_RDMA_SERVER into >> SUNRPC_XPRT_RDMA, but misses to update references in Documentation, >> see: >> >> Documentation/filesystems/nfs/nfs-rdma.txt:142: >> SUNRPC_XPRT_RDMA_CLIENT and SUNRPC_XPRT_RDMA_SERVER config options >> that both >> Documentation/filesystems/nfs/nfs-rdma.txt:242: >> (CONFIG_SUNRPC_XPRT_RDMA_SERVER=m in kernel config), load the RDMA >> Documentation/filesystems/nfs/nfs-rdma.txt:263: >> (CONFIG_SUNRPC_XPRT_RDMA_CLIENT=m in kernel config), load the RDMA >> client >> >> I guess that commit 731d5cca8272 ("Documentation: NFS/RDMA: Document >> separate Kconfig symbols") needs to be reverted as well. >> >> I detected this issue with scripts/checkkconfigsymbols.py. >> >> Kind regards, >> Valentin > > Hi, > > this is just a kind reminder that the issue above is now present in v4.2-rc1. I somehow missed your previous note. You can start by reverting commit 731d5cca8272. -- Chuck Lever -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/