Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754509AbbGFQUn (ORCPT ); Mon, 6 Jul 2015 12:20:43 -0400 Received: from mail-wi0-f177.google.com ([209.85.212.177]:37009 "EHLO mail-wi0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752281AbbGFQUj (ORCPT ); Mon, 6 Jul 2015 12:20:39 -0400 From: Pali =?utf-8?q?Roh=C3=A1r?= To: Rob Herring Subject: Re: [RESEND] [PATCH v2 1/2] arm: devtree: Set system_rev from DT revision Date: Mon, 6 Jul 2015 18:20:35 +0200 User-Agent: KMail/1.13.7 (Linux/3.13.0-55-generic; KDE/4.14.2; x86_64; ; ) Cc: Tony Lindgren , Arnd Bergmann , "linux-arm-kernel@lists.infradead.org" , Russell King , Will Deacon , Ivaylo Dimitrov , Sebastian Reichel , Pavel Machek , Andreas =?utf-8?q?F=C3=A4rber?= , "linux-omap" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" References: <1430902142-17035-1-git-send-email-pali.rohar@gmail.com> <201507061512.27124@pali> In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart2694513.j5x1bJWHGc"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201507061820.35789@pali> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2457 Lines: 91 --nextPart2694513.j5x1bJWHGc Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Monday 06 July 2015 17:22:58 Rob Herring wrote: > On Mon, Jul 6, 2015 at 8:12 AM, Pali Roh=C3=A1r wr= ote: > > On Monday 06 July 2015 14:31:27 Tony Lindgren wrote: > >> * Pali Roh=C3=A1r [150706 05:25]: > >> > into which file should I put documentation about new DT > >> > properties? > >>=20 > >> If it's Linux generic like linux,revision, then how about > >> Documentation/devicetree/bindings/revision.txt? > >>=20 > >> For the ATAGs, Documentation/devicetree/bindings/arm/atag.txt? > >>=20 > >> Regards, > >>=20 > >> Tony > >=20 > > Hm... now I'm thinking into which DT field should I put atags and > > revision. In previous emails you wrote to use "linux,atags", now > > "arm,atags"? And put them into root node? Or other? > >=20 > > In arch/arm/boot/compressed/atags_to_fdt.c code I see that most > > atag properties are converted into "/chosen" node in DT... > >=20 > > So what do you prefer for "revision" and what for "atags"? > >=20 > > Some mentioned examples: > >=20 > > "/revision" >=20 > This one. This is a top level h/w property. >=20 > > "/chosen/revision" > > "/linux,revision" > > "/chosen/linux,revision" > > ... > >=20 > > "/atags" > > "/chosen/atags" > > "/linux,atags" > > "/chosen/linux,atags" >=20 > This one. ATAGs are a Linux data struct. >=20 > Rob >=20 Ok, and how read that property "/chosen/linux,atags" in function setup_machine_fdt() from file arch/arm/kernel/devtree.c ? of_get_flat_dt_prop() cannot be used unless somebody get me offset to node "/chosen"... Any idea? > > "/arm,atags" > > "/chosen/arm,atags" > > ... > >=20 > > -- > > Pali Roh=C3=A1r > > pali.rohar@gmail.com =2D-=20 Pali Roh=C3=A1r pali.rohar@gmail.com --nextPart2694513.j5x1bJWHGc Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEABECAAYFAlWaqtMACgkQi/DJPQPkQ1L2qwCgtZWepIPRCCyWD9/08tSrKn5s doIAoLWbVp2qOcwCWo7lr0u39uFNYQ2K =Rc2x -----END PGP SIGNATURE----- --nextPart2694513.j5x1bJWHGc-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/