Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755711AbbGFQee (ORCPT ); Mon, 6 Jul 2015 12:34:34 -0400 Received: from terminus.zytor.com ([198.137.202.10]:50363 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754199AbbGFQe3 (ORCPT ); Mon, 6 Jul 2015 12:34:29 -0400 Date: Mon, 6 Jul 2015 09:33:14 -0700 From: tip-bot for Markus Elfring Message-ID: Cc: acme@redhat.com, mingo@kernel.org, tglx@linutronix.de, a.p.zijlstra@chello.nl, linux-kernel@vger.kernel.org, masami.hiramatsu.pt@hitachi.com, elfring@users.sourceforge.net, julia.lawall@lip6.fr, hpa@zytor.com Reply-To: hpa@zytor.com, julia.lawall@lip6.fr, elfring@users.sourceforge.net, masami.hiramatsu.pt@hitachi.com, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@kernel.org, a.p.zijlstra@chello.nl, acme@redhat.com In-Reply-To: <5597751A.5000506@users.sourceforge.net> References: <5597751A.5000506@users.sourceforge.net> To: linux-tip-commits@vger.kernel.org Subject: [tip:perf/core] perf probe: Delete an unnecessary check before the function call "strfilter__delete" Git-Commit-ID: 200802a4a79b3a7a1cf924ad870d3265023d0787 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1792 Lines: 44 Commit-ID: 200802a4a79b3a7a1cf924ad870d3265023d0787 Gitweb: http://git.kernel.org/tip/200802a4a79b3a7a1cf924ad870d3265023d0787 Author: Markus Elfring AuthorDate: Sat, 4 Jul 2015 07:44:22 +0200 Committer: Arnaldo Carvalho de Melo CommitDate: Mon, 6 Jul 2015 08:58:36 -0300 perf probe: Delete an unnecessary check before the function call "strfilter__delete" The strfilter__delete() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Acked-by: Masami Hiramatsu Cc: Julia Lawall Cc: Peter Zijlstra Cc: kernel-janitors@vger.kernel.org Link: http://lkml.kernel.org/r/5597751A.5000506@users.sourceforge.net Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/builtin-probe.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tools/perf/builtin-probe.c b/tools/perf/builtin-probe.c index 1272559..b81cec3 100644 --- a/tools/perf/builtin-probe.c +++ b/tools/perf/builtin-probe.c @@ -297,8 +297,7 @@ static void cleanup_params(void) clear_perf_probe_event(params.events + i); line_range__clear(¶ms.line_range); free(params.target); - if (params.filter) - strfilter__delete(params.filter); + strfilter__delete(params.filter); memset(¶ms, 0, sizeof(params)); } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/