Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754004AbbGFRHv (ORCPT ); Mon, 6 Jul 2015 13:07:51 -0400 Received: from arroyo.ext.ti.com ([192.94.94.40]:56628 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753419AbbGFRHs (ORCPT ); Mon, 6 Jul 2015 13:07:48 -0400 Date: Mon, 6 Jul 2015 12:07:46 -0500 From: Felipe Balbi To: Subbaraya Sundeep Bhatta CC: "balbi@ti.com" , "gregkh@linuxfoundation.org" , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" Subject: Re: [PATCH v2 3/3] usb: dwc3: gadget: return error if command sent to DEPCMD register fails Message-ID: <20150706170746.GA8021@saruman.tx.rr.com> Reply-To: References: <1432203408-5482-1-git-send-email-sbhatta@xilinx.com> <1432203408-5482-3-git-send-email-sbhatta@xilinx.com> <20150629214701.GK1019@saruman.tx.rr.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="rwEMma7ioTxnRzrJ" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2896 Lines: 77 --rwEMma7ioTxnRzrJ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jul 01, 2015 at 07:29:28AM +0000, Subbaraya Sundeep Bhatta wrote: > Hi Felipe, >=20 > > -----Original Message----- > > From: Felipe Balbi [mailto:balbi@ti.com] > > Sent: Tuesday, June 30, 2015 3:17 AM > > To: Subbaraya Sundeep Bhatta > > Cc: balbi@ti.com; gregkh@linuxfoundation.org; linux-usb@vger.kernel.org; > > linux-kernel@vger.kernel.org; stable@vger.kernel.org; Subbaraya Sundeep > > Bhatta > > Subject: Re: [PATCH v2 3/3] usb: dwc3: gadget: return error if command > > sent to DEPCMD register fails > >=20 > > Hi, > >=20 > > On Thu, May 21, 2015 at 03:46:48PM +0530, Subbaraya Sundeep Bhatta > > wrote: > > > We need to return error to caller if command is not sent to controller > > > succesfully. > > > > > > Signed-off-by: Subbaraya Sundeep Bhatta > > > Fixes: 72246da40f37 (usb: Introduce DesignWare USB3 DRD Driver) > > > Cc: > > > --- > > > v2 changes: > > > Added Fixes and Cc in commit message. > >=20 > > I noticed that this breaks at least my AM437x silicon with DWC3 2.40a > > when used with g_zero and testusb. As of now, it could be that silicon = is > > mis-behaving because I got a Transfer Complete before the failing Set > > Endpoint Transfer Resource command. > >=20 > > In any case, can you run on your setup with g_zero and test.sh/testusb > > [1]/[2] just to verify that it really works for you ? >=20 > Ok I will do that. Did you manage to run the test I asked ? If we don't get down to this, I'll have to revert your patch as it regresses my platforms. --=20 balbi --rwEMma7ioTxnRzrJ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVmrXiAAoJEIaOsuA1yqRE2z4QAKL3fDWpwJps8n2C+t7Emup+ OgTqHdxfEv5LcLZIu9tECW9BSEzvT3LGydVOV7XY3GoBABHeUFic4KAE4zK6Kv7d Bnp+qYmFBlsWfi/c1IakHkvQfwG15IUJIneAnKxMBR9sFeiMHCrCESVQS2HuQte3 dOG6FlUzfp47ajgGqsL0/LQiFlgSEKSfwo+KES2zZYhod95GDSVGx5H9on+81sIN uEUhjcwcSkQK6au5qCz3UFEx6al3QmR55IS7i9JYLOJRyWAQwZ9vUP0a3QDNAcY0 tOBAz+dKOWfbwTLzGHpLJCAINEkbvZmwSgU5NVnrfYWQ2DSKpZ9RPRweBHtr1EAo XfAvZ2/5x0h4SR9SdObd6TPedC14bA8e4aBu5y6Y3c+WvHaLpHIDtvaoMG5hE1Ss l32HSejodmWBa9pdAD+jgGXjJJpB+HRvJelbR9jBcbDiu3DPSBZ8kPla0T0gJsYv Y3AZYPbbzhAoMn/D8bpNdbfjt4YTV+IWdlmYtxaQQc/LvnwJMGNpJ8nBzfCfO2G+ LNSTEqKrFrPzwYoowdRS1RyyxdFiOD3zqR/YCH9gRE62DkxOW72riZA+2XbDFcDd 8Gsnk0xctDqy40huEhstLYJiY0XBgvRfYk/42x5tvcIYDhoJ9rOWo6U2CcP/8Mjz j4wMWtURx8i7C2MqzZlP =yi6K -----END PGP SIGNATURE----- --rwEMma7ioTxnRzrJ-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/