Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752126AbbGFRUp (ORCPT ); Mon, 6 Jul 2015 13:20:45 -0400 Received: from mail-la0-f45.google.com ([209.85.215.45]:33880 "EHLO mail-la0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750978AbbGFRUn (ORCPT ); Mon, 6 Jul 2015 13:20:43 -0400 MIME-Version: 1.0 In-Reply-To: <559A9821.4010600@oracle.com> References: <1433752501-15901-1-git-send-email-mingo@kernel.org> <1433752501-15901-5-git-send-email-mingo@kernel.org> <5575954F.5070408@redhat.com> <20150608185106.GA28747@gmail.com> <559A9821.4010600@oracle.com> From: Andy Lutomirski Date: Mon, 6 Jul 2015 10:20:22 -0700 Message-ID: Subject: Re: [PATCH] x86/asm/entry/64: Clean up entry_64.S To: Sasha Levin Cc: Ingo Molnar , Denys Vlasenko , "linux-kernel@vger.kernel.org" , Brian Gerst , Peter Zijlstra , Borislav Petkov , "H. Peter Anvin" , Linus Torvalds , Oleg Nesterov , Thomas Gleixner Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1388 Lines: 34 On Mon, Jul 6, 2015 at 8:00 AM, Sasha Levin wrote: > > --- entry.before.o.cmd 2015-07-06 10:48:32.110189938 -0400 > +++ entry.after.o.cmd 2015-07-06 10:48:23.509645442 -0400 > @@ -1,5 +1,5 @@ > > -entry.before.o: file format elf64-x86-64 > +entry.after.o: file format elf64-x86-64 > > > Disassembly of section .entry.text: > @@ -3961,8 +3961,8 @@ > 3b: 09 02 or %eax,(%rdx) > ... > 3d: R_X86_64_64 .entry.text > - 45: 03 3a add (%rdx),%edi > - 47: 01 3d 03 d6 00 c8 add %edi,-0x37ff29fd(%rip) # ffffffffc800d650 > + 45: 03 33 add (%rbx),%esi > + 47: 01 3d 03 d5 00 c8 add %edi,-0x37ff2afd(%rip) # ffffffffc800d550 What exactly are you doing to generate this diff? This all looks really weird. > 4d: 44 91 rex.R xchg %eax,%ecx > 4f: 93 xchg %eax,%ebx > 50: 2f (bad) For example: what on earth is the asm above? --Andy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/