Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753318AbbGFRak (ORCPT ); Mon, 6 Jul 2015 13:30:40 -0400 Received: from mail-yk0-f182.google.com ([209.85.160.182]:35918 "EHLO mail-yk0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751092AbbGFRaf convert rfc822-to-8bit (ORCPT ); Mon, 6 Jul 2015 13:30:35 -0400 MIME-Version: 1.0 In-Reply-To: <201507061820.35789@pali> References: <1430902142-17035-1-git-send-email-pali.rohar@gmail.com> <201507061512.27124@pali> <201507061820.35789@pali> From: Rob Herring Date: Mon, 6 Jul 2015 12:30:15 -0500 Message-ID: Subject: Re: [RESEND] [PATCH v2 1/2] arm: devtree: Set system_rev from DT revision To: =?UTF-8?Q?Pali_Roh=C3=A1r?= Cc: Tony Lindgren , Arnd Bergmann , "linux-arm-kernel@lists.infradead.org" , Russell King , Will Deacon , Ivaylo Dimitrov , Sebastian Reichel , Pavel Machek , =?UTF-8?Q?Andreas_F=C3=A4rber?= , linux-omap , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1993 Lines: 64 On Mon, Jul 6, 2015 at 11:20 AM, Pali Rohár wrote: > On Monday 06 July 2015 17:22:58 Rob Herring wrote: >> On Mon, Jul 6, 2015 at 8:12 AM, Pali Rohár wrote: >> > On Monday 06 July 2015 14:31:27 Tony Lindgren wrote: >> >> * Pali Rohár [150706 05:25]: >> >> > into which file should I put documentation about new DT >> >> > properties? >> >> >> >> If it's Linux generic like linux,revision, then how about >> >> Documentation/devicetree/bindings/revision.txt? >> >> >> >> For the ATAGs, Documentation/devicetree/bindings/arm/atag.txt? >> >> >> >> Regards, >> >> >> >> Tony >> > >> > Hm... now I'm thinking into which DT field should I put atags and >> > revision. In previous emails you wrote to use "linux,atags", now >> > "arm,atags"? And put them into root node? Or other? >> > >> > In arch/arm/boot/compressed/atags_to_fdt.c code I see that most >> > atag properties are converted into "/chosen" node in DT... >> > >> > So what do you prefer for "revision" and what for "atags"? >> > >> > Some mentioned examples: >> > >> > "/revision" >> >> This one. This is a top level h/w property. >> >> > "/chosen/revision" >> > "/linux,revision" >> > "/chosen/linux,revision" >> > ... >> > >> > "/atags" >> > "/chosen/atags" >> > "/linux,atags" >> > "/chosen/linux,atags" >> >> This one. ATAGs are a Linux data struct. >> >> Rob >> > > Ok, and how read that property "/chosen/linux,atags" in function > setup_machine_fdt() from file arch/arm/kernel/devtree.c ? > > of_get_flat_dt_prop() cannot be used unless somebody get me offset to > node "/chosen"... Why can't you get the offset yourself? However, why does this need to be early? It is only used to populate /proc, right? Rob -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/