Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755141AbbGFTg1 (ORCPT ); Mon, 6 Jul 2015 15:36:27 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:48967 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753243AbbGFTgY (ORCPT ); Mon, 6 Jul 2015 15:36:24 -0400 Date: Mon, 6 Jul 2015 14:35:46 -0500 From: Felipe Balbi To: Doug Anderson CC: Felipe Balbi , Greg Kroah-Hartman , John Youn , "linux-usb@vger.kernel.org" , Chris Zhong , Heiko Stuebner , Julius Werner , Andrew Bresticker , Alexandru Stan , lyz , "open list:ARM/Rockchip SoC..." , "linux-kernel@vger.kernel.org" Subject: Re: [REPOST PATCH 3/3] USB: dwc2: Don't turn off the usbphy in suspend if wakeup is enabled Message-ID: <20150706193546.GP20779@saruman.tx.rr.com> Reply-To: References: <1436207224-21849-1-git-send-email-dianders@chromium.org> <1436207224-21849-4-git-send-email-dianders@chromium.org> <20150706183404.GI20779@saruman.tx.rr.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="qd/SZIFVu+MYwfCR" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2101 Lines: 61 --qd/SZIFVu+MYwfCR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jul 06, 2015 at 12:32:56PM -0700, Doug Anderson wrote: > Felipe, >=20 > On Mon, Jul 6, 2015 at 11:34 AM, Felipe Balbi wrote: > > Hi, > > > > On Mon, Jul 06, 2015 at 11:27:04AM -0700, Douglas Anderson wrote: > >> @@ -282,6 +296,28 @@ static int dwc2_driver_probe(struct platform_devi= ce *dev) > >> return retval; > >> } > >> > >> +static bool __maybe_unused dwc2_can_poweroff_phy(struct dwc2_hsotg *d= wc2) > >> +{ > >> + struct usb_device *root_hub =3D dwc2_hsotg_to_hcd(dwc2)->self.ro= ot_hub; > > > > what happens on peripheral only builds ? >=20 > The function is only called on if "dwc2_is_device_mode(dwc2)" returns > false. I think that means we're safe, right? heh, missed that. Should be safe, yeah. --=20 balbi --qd/SZIFVu+MYwfCR Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVmtiSAAoJEIaOsuA1yqREuz8P/jFFlDUJnFItxZc9XFG3go7V VO5xG3TiapbVpzjTQ1QjI/0Zjk83Lv58sa/cP3+khqkKrO85vRPuRagaax1EKdpo 6c6pek63F1XXESqQXcxrABHg57OXCsjO8d8Noxn8Rk2jrKJMBuWNq8R2fyEqf7hX 3YLHhJnA67jS7894X5E4Z3T2MOVpDgdew869arH6q4nZKk+nqvxJM0Xm4v+G35dY 01o8dWBsAMvHk6cRs7GWPF9G1nWY0BfVyAHdQzrl7KnBuRg+6KNWGA/8ZxeD4Rvu iGHQdhhfoOwogCdU/w2hC0Qa9LC0n4D2IaXrW0zaFh/n2Z1OEMXHeTfO2NRdlHv0 hhY9T48Zhbt+d89mVjd40c1B9LI46mzugSf3YjXftXaCIVobRQxpgaM8gdETgji+ FlvSSBdquZWKEXG3tm8LgrjJKu2WX6iw8OE++ozWiXkFtab7zYxW91X7aQumU7PT Uc7AZgYTVTFWmX1IPZpHQS6TL6Qub6Y5vbf1cKHsPYGA8spOYZ+0TxC/LSrnocLI 3dfCLh0J5pOpmLco+nr4i4s0lRIlIGvuHIRlftgc8fZ/540wNu8mru2S2Bp7R7fO wTVy1sjSE1lndHjh0IxcsYK00vFDhqIwGjESd6DT5GQLtbDpnAqyDY6R3VscVClw F2cI7W51O1VHiQGDbio/ =lZJM -----END PGP SIGNATURE----- --qd/SZIFVu+MYwfCR-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/