Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753533AbbGGGp5 (ORCPT ); Tue, 7 Jul 2015 02:45:57 -0400 Received: from mail-wi0-f176.google.com ([209.85.212.176]:32985 "EHLO mail-wi0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751723AbbGGGps (ORCPT ); Tue, 7 Jul 2015 02:45:48 -0400 Date: Tue, 7 Jul 2015 08:45:42 +0200 From: Ingo Molnar To: Anshul Garg Cc: peterz@infradead.org, hpa@zytor.com, Linus Torvalds , Linux Kernel Mailing List , tglx@linutronix.de, linux-tip-commits@vger.kernel.org Subject: Re: [tip:sched/core] sched/rt: Fix memory leak in alloc_rt_sched_group() Message-ID: <20150707064542.GA7099@gmail.com> References: <1435778966-36415-1-git-send-email-aksgarg1989@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1003 Lines: 36 * Anshul Garg wrote: > Dear linux community, > > I think this patch" sched/rt: Fix memory leak in > alloc_rt_sched_group()" with Commit-ID: > ecdd6804b7c9e15fe8fc836ba0233d9912834e8b is not correct. > > As it will create panic in case of kzalloc failure because of doingkfree twice. > > As if alloc_rt_sched_group fails it will return zero then core.c will > call free_sched_group in core.c > which subsequently calls free_rt_sched_group . > > In free_rt_sched_group memory is getting freed properly. > > so it seems patch sent by me is not correct. > > Please help to review patch once again as it might break some things. > > Sorry for inconvenience. > > Thanks > Anshul Garg Ok, I've removed this patch. Thanks! Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/