Date: Tue, 7 Jul 2015 12:24:49 +0530
From: Viresh Kumar <viresh.kumar@linaro.org>
To: Pan Xinhui <xinhuix.pan@intel.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        linux-pm@vger.kernel.org, rjw@rjwysocki.net,
        "yanmin_zhang@linux.intel.com" <yanmin_zhang@linux.intel.com>,
        "mnipxh@163.com" <mnipxh@163.com>
Subject: Re: [PATCH] acpi-cpufreq.c: fix a memory leak in
 acpi_cpufreq_cpu_exit
Message-ID: <20150707065449.GD14598@linux>
References: <559A2073.1000301@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <559A2073.1000301@intel.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1072
Lines: 31

On 06-07-15, 14:30, Pan Xinhui wrote:
> 
> policy->cpu in acpi_cpufreq_cpu_init/exit is the same cpu in most cases.
> However during cpu hotplug,
> cpufreq core might nominate a new cpu for policy->cpu.

Why aren't above lines well aligned? A simple trick to share for vim
users:

- Select lines you want to auto-align with shift+v and up-down keys
- press gq
- That's it and vim will do it for you. You need to set vim's
  'textwidth' to 72 or 80, based on what you are editing, so that vim
  knows where you need to break the line. I have this in vimrc

        set textwidth=80
        au FileType gitcommit set textwidth=72


Back to the real stuff. Few core changes have gone into v4.2-rc1 and
policy->cpu doesn't change any longer on hotplug (unless its a
physical hotplug). So you shouldn't see any issues.

-- 
viresh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/