Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754932AbbGGHCy (ORCPT ); Tue, 7 Jul 2015 03:02:54 -0400 Received: from mail-yk0-f176.google.com ([209.85.160.176]:33486 "EHLO mail-yk0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754657AbbGGHCo convert rfc822-to-8bit (ORCPT ); Tue, 7 Jul 2015 03:02:44 -0400 MIME-Version: 1.0 In-Reply-To: <1743547.3D2D8THGkI@diego> References: <1429195312-25898-1-git-send-email-orjan.eide@arm.com> <1743547.3D2D8THGkI@diego> From: Daniel Kurtz Date: Tue, 7 Jul 2015 15:02:21 +0800 X-Google-Sender-Auth: N5GnAa6sh04V9vBs6GhiU90Y9lc Message-ID: Subject: Re: [PATCH 1/2] drm: rockchip: Don't pass DRM fake offset to dma-api To: =?UTF-8?Q?Heiko_St=C3=BCbner?= , Russell King Cc: "open list:ARM/Rockchip SoC..." , =?UTF-8?B?5aea5pm65oOF?= , =?UTF-8?Q?=C3=98rjan_Eide?= , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , dri-devel Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2129 Lines: 57 On Sun, Apr 19, 2015 at 12:55 AM, Heiko Stübner wrote: > > Am Donnerstag, 16. April 2015, 16:41:51 schrieb Ørjan Eide: > > Set vm_pgoff to 0 after using it to look up the GEM node, before passing > > it on rockchip_gem_mmap_buf() where the offset must be from the start of > > the buffer. > > > > Passing in the fake offset currently works because the > > dma_mmap_attrs implementation that is used for this device, > > arm_iommu_mmap_attrs, ignores the offset completely. > > > > Signed-off-by: Ørjan Eide > > both patches on a rk3288-veyron-pinky > > Tested-by: Heiko Stuebner > > Through which tree do you want to take these patches? I guess the rockchip-drm > related patch should go through the tree that will take the dma-mapping patch, > so you'll probably need an "Ack" from Mark Yao (Cc'ed). As far as I can tell, these two patches ([0] & [1]) were never picked up. Russell, can you pick both of them up in your tree? [0] https://patchwork.kernel.org/patch/6226591/ [1] https://patchwork.kernel.org/patch/6226581/ -Dan > Heiko > > > --- > > drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c > > b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c index 7ca8799e..69f01c3 > > 100644 > > --- a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c > > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c > > @@ -94,6 +94,11 @@ int rockchip_gem_mmap(struct file *filp, struct > > vm_area_struct *vma) return -EACCES; > > } > > > > + /* Set vm_pgoff (used as a fake buffer offset by DRM) to 0 and map the > > + * whole buffer from the start. > > + */ > > + vma->vm_pgoff = 0; > > + > > obj = container_of(node, struct drm_gem_object, vma_node); > > ret = rockchip_gem_mmap_buf(obj, vma); > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/