From: Pavel Fedin <p.fedin@samsung.com>
To: "'Andre Przywara'" <andre.przywara@arm.com>,
        "'Eric Auger'" <eric.auger@linaro.org>,
        "'Paolo Bonzini'" <pbonzini@redhat.com>,
        "'Christoffer Dall'" <christoffer.dall@linaro.org>
Cc: eric.auger@st.com, linux-arm-kernel@lists.infradead.org,
        "'Marc Zyngier'" <Marc.Zyngier@arm.com>, kvmarm@lists.cs.columbia.edu,
        kvm@vger.kernel.org, linux-kernel@vger.kernel.org
References: <1435592237-17924-1-git-send-email-eric.auger@linaro.org>
 <1435592237-17924-2-git-send-email-eric.auger@linaro.org>
 <011f01d0b498$6a17aeb0$3e470c10$@samsung.com> <5596503E.6040902@arm.com>
 <00fd01d0b7b6$f6cf3550$e46d9ff0$@samsung.com> <559A3C9C.6050302@arm.com>
 <20150706093026.GA11590@cbox> <559A52E6.5050402@arm.com>
 <20150706103755.GC11590@cbox> <559A6164.1000401@redhat.com>
 <559A6527.1040107@arm.com> <559A6BBC.2040901@redhat.com>
 <024301d0b7f0$2b13b410$813b1c30$@samsung.com> <559A9854.2090607@linaro.org>
 <559AA449.80705@arm.com>
In-reply-to: <559AA449.80705@arm.com>
Subject: RE: [PATCH 1/7] KVM: api: add kvm_irq_routing_extended_msi
Date: Tue, 07 Jul 2015 10:23:29 +0300
Message-id: <014d01d0b885$d3228380$79678a80$@samsung.com>
MIME-version: 1.0
Content-type: text/plain; charset=us-ascii
Content-transfer-encoding: 7bit
Thread-index: AQIj+X5s5FdAGWwAOFAf7dE3NOV/zwG0/EgbAfNFYEkCdP68yAI2kmrgAcGjK5UBdOO3AQInn0A7AhPZAhABkKKCDwD4t3eDAoJbRakDRTGpLgL2uZX3AfUqNYCcQQJqgA==
Content-language: ru
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1043
Lines: 25

 Hi!

> I guess not. But I prefer the new type anyway, as it also has a known
> error path for older kernels.

 flags != 0 has known error path too, and it's absolutely the same.
 Sorry, read this after writing my previous reply, so this is a short addendum.

 I see lots of people agreed on a new type. If my argument about reusing existing definitions is not
enough, you can ignore it. Three people beat one definitely. :)
 And yes, since we are talking about it, actually KVM_MSI_VALID_DEVID flag is not yet a part of
mainline, so it's not set in stone. Then, perhaps you could throw it away completely and invent
KVM_SIGNAL_EXT_MSI ioctl for sending MSIs with device ID. This would also be consistent IMO.

Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/