From: Matthias Brugger <matthias.bgg@gmail.com>
To: Daniel Kurtz <djkurtz@chromium.org>
Cc: Koro Chen <koro.chen@mediatek.com>,
        srv_heupstream <srv_heupstream@mediatek.com>,
        linux-mediatek@lists.infradead.org,
        Sascha Hauer <s.hauer@pengutronix.de>,
        "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        alsa-devel@alsa-project.org,
        "open list:OPEN FIRMWARE AND..." <devicetree@vger.kernel.org>,
        Nicolas Boichat <drinkcat@chromium.org>
Subject: Re: [PATCH] arm64: dts: mt8173: Add afe device node
Date: Tue, 07 Jul 2015 09:46:55 +0200
Message-ID: <25205102.t939MQMDBD@ubix>
User-Agent: KMail/4.13.3 (Linux/3.13.0-55-generic; KDE/4.13.3; x86_64; ; )
In-Reply-To: <CAGS+omCOzJs=VWboU_7doUum6BEfmh1hV88HmJiin2c-A_n_Mw@mail.gmail.com>
References: <1436165530-41963-1-git-send-email-koro.chen@mediatek.com> <CAGS+omCOzJs=VWboU_7doUum6BEfmh1hV88HmJiin2c-A_n_Mw@mail.gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1798
Lines: 53

On Monday, July 06, 2015 09:02:38 PM Daniel Kurtz wrote:
> On Mon, Jul 6, 2015 at 2:52 PM, Koro Chen <koro.chen@mediatek.com> wrote:
> > This adds afe (audio front end) device node to the MT8173 dtsi file.
> > 
> > This patch is based on Matthias's tree:
> > https://github.com/mbgg/linux-mediatek
> > branch: v4.2-next/arm64
> > 
> > Signed-off-by: Koro Chen <koro.chen@mediatek.com>
> > ---
> > 
> >  arch/arm64/boot/dts/mediatek/mt8173.dtsi | 32
> >  ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > b/arch/arm64/boot/dts/mediatek/mt8173.dtsi index 0696f8f..f8afab4 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > @@ -14,6 +14,7 @@
> > 
> >  #include <dt-bindings/clock/mt8173-clk.h>
> >  #include <dt-bindings/interrupt-controller/irq.h>
> >  #include <dt-bindings/interrupt-controller/arm-gic.h>
> > 
> > +#include <dt-bindings/power/mt8173-power.h>
> > 
> >  #include <dt-bindings/reset-controller/mt8173-resets.h>
> >  #include "mt8173-pinfunc.h"
> > 
> > @@ -393,6 +394,37 @@
> > 
> >                         #size-cells = <0>;
> >                         status = "disabled";
> >                 
> >                 };
> > 
> > +
> > +               afe: mt8173-afe-pcm@11220000  {
> 
> I believe this should be something generic, like:
> 
>   afe: audio-controller@11220000
> 

Yes, please find a name that better describes the component instead of just 
using the compatible string.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/