Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752739AbbGGHvk (ORCPT ); Tue, 7 Jul 2015 03:51:40 -0400 Received: from mail-wi0-f179.google.com ([209.85.212.179]:32865 "EHLO mail-wi0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751041AbbGGHvd (ORCPT ); Tue, 7 Jul 2015 03:51:33 -0400 From: Matthias Brugger To: Eddie Huang Cc: Henry Chen , Daniel Kurtz , Sascha Hauer , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-mediatek@lists.infradead.org" Subject: Re: [PATCH] arm64: dts: mt8173-evb: Add PMIC support Date: Tue, 07 Jul 2015 09:51:28 +0200 Message-ID: <3123164.GB0TYlAtQ5@ubix> User-Agent: KMail/4.13.3 (Linux/3.13.0-55-generic; KDE/4.13.3; x86_64; ; ) In-Reply-To: <1436238590.19228.4.camel@mtksdaap41> References: <1434979177-7575-1-git-send-email-henryc.chen@mediatek.com> <1727643.5AqCaKisXT@ubix> <1436238590.19228.4.camel@mtksdaap41> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2072 Lines: 57 On Tuesday, July 07, 2015 11:09:50 AM Eddie Huang wrote: > On Mon, 2015-07-06 at 18:39 +0200, Matthias Brugger wrote: > > On Monday, July 06, 2015 03:43:57 PM Eddie Huang wrote: > > > On Mon, 2015-06-22 at 21:19 +0800, Henry Chen wrote: > > > > From: Eddie Huang > > [...] > > > > > diff --git a/arch/arm64/boot/dts/mediatek/mt8173-evb.dts > > > > b/arch/arm64/boot/dts/mediatek/mt8173-evb.dts index 43d5401..b967914 > > > > 100644 > > > > --- a/arch/arm64/boot/dts/mediatek/mt8173-evb.dts > > > > +++ b/arch/arm64/boot/dts/mediatek/mt8173-evb.dts > > > > @@ -33,6 +33,180 @@ > > > > > > > > chosen { }; > > > > > > > > }; > > > > > > > > +&pwrap { > > > > + pmic: mt6397 { > > > > + compatible = "mediatek,mt6397"; > > > > + interrupt-parent = <&pio>; > > > > + interrupts = <11 IRQ_TYPE_LEVEL_HIGH>; > > > > + interrupt-controller; > > > > + #interrupt-cells = <2>; > > > > + > > > > + mt6397regulator: mt6397regulator { > > > > + compatible = "mediatek,mt6397-regulator"; > > > > + mt6397_vpca15_reg: buck_vpca15 { > > > > + regulator-compatible = "buck_vpca15"; > > > > + regulator-name = "vpca15"; > > > > + regulator-min-microvolt = < 700000>; > > > > + regulator-max-microvolt = <1350000>; > > > > + regulator-ramp-delay = <12500>; > > > > + regulator-always-on; > > > > > > I see you pull da9211 regulator dts patch, but not this one. How about > > > this patch ? > > > > I inserted some new-lines and added it to v4.2-next/arm64 > > Thanks the pull. Normally we put alias node in alphabetical order, make > later merge more easily. I think you can do the modification and squeeze > into the same commit. > I used the order of the dtsi file, but I think your approach is more straight forward. I will change that. Thanks for your comment. Matthias -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/