Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932115AbbGGIuE (ORCPT ); Tue, 7 Jul 2015 04:50:04 -0400 Received: from mail-la0-f49.google.com ([209.85.215.49]:34810 "EHLO mail-la0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756725AbbGGItu (ORCPT ); Tue, 7 Jul 2015 04:49:50 -0400 From: Sumit Saxena References: <1436199198-16415-1-git-send-email-xerofoify@gmail.com> In-Reply-To: <1436199198-16415-1-git-send-email-xerofoify@gmail.com> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 14.0 Thread-Index: AQHLgkEAjI3Cq1+tb1T4NOhpsOm3ZZ3aHy6A Date: Tue, 7 Jul 2015 14:19:46 +0530 Message-ID: <3970836098e4580f9199a91daa257c48@mail.gmail.com> Subject: RE: [PATCH] megaraid:Remove no longer required variable ret from the function megasas_sync_map_info To: Nicholas Krause , Kashyap Desai Cc: Uday Lingala , JBottomley@odin.com, "PDL,MEGARAIDLINUX" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1970 Lines: 54 -----Original Message----- From: Nicholas Krause [mailto:xerofoify@gmail.com] Sent: Monday, July 06, 2015 9:43 PM To: kashyap.desai@avagotech.com Cc: sumit.saxena@avagotech.com; uday.lingala@avagotech.com; JBottomley@odin.com; megaraidlinux.pdl@avagotech.com; linux-scsi@vger.kernel.org; linux-kernel@vger.kernel.org Subject: [PATCH] megaraid:Remove no longer required variable ret from the function megasas_sync_map_info This removes the no longer required variable ret due to this variable only ever being used at the end of the function megasas_sync_map_info without changing it's value from the orginal setting of its value to zero due to this just remove the variable ret and just return the value of zero directly here in order to indicate to the caller the call to this function has run successfully without any non recoverable issues. Signed-off-by: Nicholas Krause --- drivers/scsi/megaraid/megaraid_sas_fusion.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c b/drivers/scsi/megaraid/megaraid_sas_fusion.c index 46a0f8f..b5a8c65 100644 --- a/drivers/scsi/megaraid/megaraid_sas_fusion.c +++ b/drivers/scsi/megaraid/megaraid_sas_fusion.c @@ -836,7 +836,7 @@ megasas_get_map_info(struct megasas_instance *instance) int megasas_sync_map_info(struct megasas_instance *instance) { - int ret = 0, i; + int i; struct megasas_cmd *cmd; struct megasas_dcmd_frame *dcmd; u32 size_sync_info, num_lds; @@ -906,7 +906,7 @@ megasas_sync_map_info(struct megasas_instance *instance) instance->instancet->issue_dcmd(instance, cmd); - return ret; + return 0; } Acked-by: Sumit Saxena /* -- 2.1.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/