Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756747AbbGGJUX (ORCPT ); Tue, 7 Jul 2015 05:20:23 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:49900 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1754218AbbGGJUQ (ORCPT ); Tue, 7 Jul 2015 05:20:16 -0400 X-Listener-Flag: 11101 Message-ID: <1436260809.4347.2.camel@mtksdaap41> Subject: Re: [PATCH] arm64: dts: mt8173: Add afe device node From: Koro Chen To: Matthias Brugger CC: Daniel Kurtz , "open list:OPEN FIRMWARE AND..." , Nicolas Boichat , srv_heupstream , Sascha Hauer , "linux-kernel@vger.kernel.org" , , , "linux-arm-kernel@lists.infradead.org" Date: Tue, 7 Jul 2015 17:20:09 +0800 In-Reply-To: <25205102.t939MQMDBD@ubix> References: <1436165530-41963-1-git-send-email-koro.chen@mediatek.com> <25205102.t939MQMDBD@ubix> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2194 Lines: 63 On Tue, 2015-07-07 at 09:46 +0200, Matthias Brugger wrote: > On Monday, July 06, 2015 09:02:38 PM Daniel Kurtz wrote: > > On Mon, Jul 6, 2015 at 2:52 PM, Koro Chen wrote: > > > This adds afe (audio front end) device node to the MT8173 dtsi file. > > > > > > This patch is based on Matthias's tree: > > > https://github.com/mbgg/linux-mediatek > > > branch: v4.2-next/arm64 > > > > > > Signed-off-by: Koro Chen > > > --- > > > > > > arch/arm64/boot/dts/mediatek/mt8173.dtsi | 32 > > > ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+) > > > > > > diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi > > > b/arch/arm64/boot/dts/mediatek/mt8173.dtsi index 0696f8f..f8afab4 100644 > > > --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi > > > +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi > > > @@ -14,6 +14,7 @@ > > > > > > #include > > > #include > > > #include > > > > > > +#include > > > > > > #include > > > #include "mt8173-pinfunc.h" > > > > > > @@ -393,6 +394,37 @@ > > > > > > #size-cells = <0>; > > > status = "disabled"; > > > > > > }; > > > > > > + > > > + afe: mt8173-afe-pcm@11220000 { > > > > I believe this should be something generic, like: > > > > afe: audio-controller@11220000 > > > > Yes, please find a name that better describes the component instead of just > using the compatible string. > Thanks both, I will change the name to audio-controller. > Thanks. > > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-mediatek -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/