From: Dexuan Cui <decui@microsoft.com>
To: Paul Bolle <pebolle@tiscali.nl>
CC: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "driverdev-devel@linuxdriverproject.org" 
	<driverdev-devel@linuxdriverproject.org>,
        "olaf@aepfle.de" <olaf@aepfle.de>,
        "apw@canonical.com" <apw@canonical.com>,
        "jasowang@redhat.com" <jasowang@redhat.com>,
        KY Srinivasan <kys@microsoft.com>,
        Haiyang Zhang <haiyangz@microsoft.com>
Subject: RE: [PATCH 6/7] hvsock: introduce Hyper-V VM Sockets feature
Thread-Topic: [PATCH 6/7] hvsock: introduce Hyper-V VM Sockets feature
Thread-Index: AQHQuJia2uH1a74wRkupK8dXvLERIJ3PxhuQ
Date: Tue, 7 Jul 2015 10:02:55 +0000
Message-ID: <1e0b3449110c487d8ed033c6f853285a@SIXPR30MB031.064d.mgd.msft.net>
References: <1436194049-27829-1-git-send-email-decui@microsoft.com>
 <1436261876.20057.132.camel@tiscali.nl>
In-Reply-To: <1436261876.20057.132.camel@tiscali.nl>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jul 2015 10:03:01.4969
 (UTC)
X-MS-Exchange-CrossTenant-Id: 72f988bf-86f1-41af-91ab-2d7cd011db47
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=72f988bf-86f1-41af-91ab-2d7cd011db47;Ip=[206.191.229.116];Helo=[064-smtp-out.microsoft.com]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR0301MB0664
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id t67AZsVv014305
Content-Length: 1463
Lines: 54

> -----Original Message-----
> From: Paul Bolle
> Sent: Tuesday, July 7, 2015 17:38
> To: Dexuan Cui
> Subject: Re: [PATCH 6/7] hvsock: introduce Hyper-V VM Sockets feature
> 
> Just two nits.
> 
> On ma, 2015-07-06 at 07:47 -0700, Dexuan Cui wrote:
> > --- /dev/null
> > +++ b/net/hv_sock/Kconfig
> 
> > +config HYPERV_SOCK
> > +	tristate "Microsoft Hyper-V Socket (EXPERIMENTAL)"
> > +	depends on HYPERV
> > +	default m
> > +	help
> > +	  Hyper-V Socket is a socket protocol similar to TCP, allowing
> > +	  communication between a Linux guest and the host.
> > +
> > +	  To compile this driver as a module, choose M here: the module
> > +	  will be called hv_sock. If unsure, say N.
> 
> It's a bit odd to advise to say N if one is unsure and set the default
> to 'm' at the same time.
Hi Paul,
Thanks for the suggestion!
I'll change the 'default' to n in V2.

> > --- /dev/null
> > +++ b/net/hv_sock/af_hvsock.c
> 
> > +static int hvsock_init(void)
> > +{
> > +	[...]
> > +}
> > +
> > +static void hvsock_exit(void)
> > +{
> > +	[...]
> > +}
> > +
> > +module_init(hvsock_init);
> > +module_exit(hvsock_exit);
> 
> Any specific reason not to mark these functions __init and __exit?
> 
> Paul Bolle
Thanks for pointing this out -- I missed that. 
I'll add __init and __exit in V2.

Thanks,
-- Dexuan
????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m????????????I?