Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756989AbbGGMdb (ORCPT <rfc822;w@1wt.eu>);
	Tue, 7 Jul 2015 08:33:31 -0400
Received: from mail-ig0-f171.google.com ([209.85.213.171]:33502 "EHLO
	mail-ig0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1756672AbbGGMdW (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 7 Jul 2015 08:33:22 -0400
MIME-Version: 1.0
In-Reply-To: <1436240327-181705-1-git-send-email-wangnan0@huawei.com>
References: <1436240327-181705-1-git-send-email-wangnan0@huawei.com>
From: Namhyung Kim <namhyung@kernel.org>
Date: Tue, 7 Jul 2015 21:33:02 +0900
X-Google-Sender-Auth: msp96JaX5WTKdsxfHni9cVGuaio
Message-ID: <CAM9d7cg3wL1iVVaOr2jGG60QXO-huvv-mV9tauU2om0nEH0sHw@mail.gmail.com>
Subject: Re: [PATCH v2] perf tools: Allow passing perf's own pid to '--filter'
To: Wang Nan <wangnan0@huawei.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>, Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Jiri Olsa <jolsa@kernel.org>, Peter Zijlstra <peterz@infradead.org>,
        "Liang, Kan" <kan.liang@intel.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Andi Kleen <ak@linux.intel.com>, jacob.w.shin@gmail.com,
        standby24x7@gmail.com, Li Zefan <lizefan@huawei.com>,
        yunlong.song@huawei.com, Steven Rostedt <rostedt@goodmis.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        pi3orama@163.com
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1919
Lines: 62

Hi,

On Tue, Jul 7, 2015 at 12:38 PM, Wang Nan <wangnan0@huawei.com> wrote:
> This patch allows passing perf's own PID to '--filter' by using
> '$PERFPID'. This should be useful when system-widely capturing
> tracepoints events.
>
> Before this patch, when doing something like:
>
>  # perf record -a -e syscalls:sys_enter_write <cmd>
>
> One could easily get result like this:
>
>  # perf report --stdio
>  ...
>  # Overhead  Command  Shared Object       Symbol
>  # ........  .......  ..................  ....................
>  #
>      99.99%  perf     libpthread-2.18.so  [.] __write_nocancel
>      0.01%   ls       libc-2.18.so        [.] write
>      0.01%   sshd     libc-2.18.so        [.] write
>      ...
>
> Where most events are generated by perf itself.
>
> A shell trick can be done to filter perf itself out:
>
>  # cat << EOF > ./tmp
>  > #!/bin/sh
>  > exec perf record -e ... --filter="common_pid != \$\$" -a sleep 10
>  > EOF
>  # chmod a+x ./tmp
>  # ./tmp
>
> However, doing so is user unfriendly.
>
> This patch introduces '$PERFPID' placeholder to perf's filter. Now
> user is allowed to do the above work with:
>
>   # perf record -e ... --filter='common_pid != $PERFPID' -a sleep 10

Instead, what about adding an option to do the same thing, like
--exclude-perf or something?

Thanks,
Namhyung


>
> This patch adds the variable replacement code to perf_evsel__apply_filter(),
> before PERF_EVENT_IOC_SET_FILTER ioctl, so not only 'perf record', all
> subcommands which uses filter can utilize $PERFPID.
>
> Andi Kleen sent a similar patch at 2014, but wasn't applied, the
> reason is not clear.
>
> Signed-off-by: Wang Nan <wangnan0@huawei.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/