Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757283AbbGGMrK (ORCPT ); Tue, 7 Jul 2015 08:47:10 -0400 Received: from mail-wi0-f182.google.com ([209.85.212.182]:37123 "EHLO mail-wi0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756457AbbGGMrA (ORCPT ); Tue, 7 Jul 2015 08:47:00 -0400 Date: Tue, 7 Jul 2015 13:46:54 +0100 From: Lee Jones To: Axel Lin Cc: Mark Brown , patches@opensource.wolfsonmicro.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mfd: wm8994-regmap: Constify reg_default tables Message-ID: <20150707124654.GC3182@x1> References: <1436267459.6600.1.camel@ingics.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1436267459.6600.1.camel@ingics.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2075 Lines: 54 On Tue, 07 Jul 2015, Axel Lin wrote: > These reg_default tables are not modified after initialized, so make them > const. > > Signed-off-by: Axel Lin > --- > drivers/mfd/wm8994-regmap.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Applied, thanks. > diff --git a/drivers/mfd/wm8994-regmap.c b/drivers/mfd/wm8994-regmap.c > index 300e9b6..c56b160 100644 > --- a/drivers/mfd/wm8994-regmap.c > +++ b/drivers/mfd/wm8994-regmap.c > @@ -19,7 +19,7 @@ > > #include "wm8994.h" > > -static struct reg_default wm1811_defaults[] = { > +static const struct reg_default wm1811_defaults[] = { > { 0x0001, 0x0000 }, /* R1 - Power Management (1) */ > { 0x0002, 0x6000 }, /* R2 - Power Management (2) */ > { 0x0003, 0x0000 }, /* R3 - Power Management (3) */ > @@ -251,7 +251,7 @@ static struct reg_default wm1811_defaults[] = { > { 0x0748, 0x003F }, /* R1864 - IRQ Debounce */ > }; > > -static struct reg_default wm8994_defaults[] = { > +static const struct reg_default wm8994_defaults[] = { > { 0x0001, 0x0000 }, /* R1 - Power Management (1) */ > { 0x0002, 0x6000 }, /* R2 - Power Management (2) */ > { 0x0003, 0x0000 }, /* R3 - Power Management (3) */ > @@ -470,7 +470,7 @@ static struct reg_default wm8994_defaults[] = { > { 0x0748, 0x003F }, /* R1864 - IRQ Debounce */ > }; > > -static struct reg_default wm8958_defaults[] = { > +static const struct reg_default wm8958_defaults[] = { > { 0x0001, 0x0000 }, /* R1 - Power Management (1) */ > { 0x0002, 0x6000 }, /* R2 - Power Management (2) */ > { 0x0003, 0x0000 }, /* R3 - Power Management (3) */ -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/