Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757078AbbGGMuq (ORCPT ); Tue, 7 Jul 2015 08:50:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35054 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756979AbbGGMui (ORCPT ); Tue, 7 Jul 2015 08:50:38 -0400 Date: Tue, 7 Jul 2015 08:50:36 -0400 (EDT) From: Mikulas Patocka X-X-Sender: mpatocka@file01.intranet.prod.int.rdu2.redhat.com To: Mike Snitzer cc: "Alasdair G. Kergon" , Edward Thornber , dm-devel@redhat.com, David Rientjes , Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/7] dm: introduce dm_kvmalloc In-Reply-To: <20150706134750.GA31600@redhat.com> Message-ID: References: <20150706134750.GA31600@redhat.com> User-Agent: Alpine 2.02 (LRH 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1021 Lines: 28 On Mon, 6 Jul 2015, Mike Snitzer wrote: > In general I like what you've done with this patchset _except_ I'm not > seeing why dm_kvmalloc() should be in DM at all. It should probably be > elevated to an kvmalloc() export from mm/util.c and include/linux/mm.h > along-side kvfree(). If memory management maintainers agree to put it into mm core, it would be nice. If not, put it into device mapper. Mikulas > David and/or Andrew, what do you think? > > FYI, full patchset starts here: > https://www.redhat.com/archives/dm-devel/2015-July/msg00004.html > > (but Mikulas didn't chain the reply so the 7 patches aren't properly > threaded/navigated, you can dig out the patches toward the top of the > list here: https://patchwork.kernel.org/project/dm-devel/list/ ) > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/