Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757021AbbGGNWw (ORCPT ); Tue, 7 Jul 2015 09:22:52 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48484 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753764AbbGGNWm (ORCPT ); Tue, 7 Jul 2015 09:22:42 -0400 Subject: Re: [RFC v2 3/6] irq: bypass: Extend skeleton for ARM forwarding control To: "Wu, Feng" , Eric Auger , "eric.auger@st.com" , "linux-arm-kernel@lists.infradead.org" , "kvmarm@lists.cs.columbia.edu" , "kvm@vger.kernel.org" , "christoffer.dall@linaro.org" , "marc.zyngier@arm.com" , "alex.williamson@redhat.com" , "avi.kivity@gmail.com" , "mtosatti@redhat.com" , "joro@8bytes.org" , "b.reynal@virtualopensystems.com" References: <1436184692-20927-1-git-send-email-eric.auger@linaro.org> <1436184692-20927-4-git-send-email-eric.auger@linaro.org> <559BB167.1030603@redhat.com> <559BB463.6090406@redhat.com> <559BB642.5010701@redhat.com> Cc: "linux-kernel@vger.kernel.org" , "patches@linaro.org" From: Paolo Bonzini Message-ID: <559BD29A.9000208@redhat.com> Date: Tue, 7 Jul 2015 15:22:34 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 962 Lines: 23 On 07/07/2015 13:33, Wu, Feng wrote: >>> > > The need to store the consumer->producer link seems to be unique to >>> > > posted interrupts. It is difficult to say without seeing the PI code, >>> > > but I prefer to keep the bypass manager as small as possible. >> > >> > Fine. I will follow your suggestion! > If using the following changes, how can we assign 'prod', we need to use > container_of to get struct kvm_kernel_irqfd and then refer to 'prod', but > we cannot do this in irq_bypass_register_consumer(), right? It is a > common API. But we can only get the associated producer info inside > bypass manager, right? KVM's add_producer and del_producer callbacks do have a pointer to the producer. Paolo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/