Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757853AbbGGOKp (ORCPT ); Tue, 7 Jul 2015 10:10:45 -0400 Received: from mail-la0-f42.google.com ([209.85.215.42]:35007 "EHLO mail-la0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757338AbbGGOKg (ORCPT ); Tue, 7 Jul 2015 10:10:36 -0400 Subject: Re: [PATCH 4/5] staging: emxx_udc: add missing usb_ep_set_maxpacket_limit() To: Robert Baldyga , gregkh@linuxfoundation.org, balbi@ti.com References: <1436277773-14274-1-git-send-email-r.baldyga@samsung.com> <1436277773-14274-5-git-send-email-r.baldyga@samsung.com> Cc: devel@driverdev.osuosl.org, hamohammed.sa@gmail.com, chris@rorvick.com, tapaswenipathak@gmail.com, linux-usb@vger.kernel.org, nicolas.ferre@atmel.com, hgujulan@visteon.com, mina86@mina86.com, linux-kernel@vger.kernel.org, vinc94@gmail.com, roberta.dobrescu@gmail.com, andrzej.p@samsung.com, linux-arm-kernel@lists.infradead.org, m.szyprowski@samsung.com From: Sergei Shtylyov Message-ID: <559BDDD8.1060902@cogentembedded.com> Date: Tue, 7 Jul 2015 17:10:32 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.0.1 MIME-Version: 1.0 In-Reply-To: <1436277773-14274-5-git-send-email-r.baldyga@samsung.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1120 Lines: 35 Hello. On 7/7/2015 5:02 PM, Robert Baldyga wrote: > Should use usb_ep_set_maxpacket_limit instead of setting > maxpacket value manually. > Signed-off-by: Robert Baldyga > --- > drivers/staging/emxx_udc/emxx_udc.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > diff --git a/drivers/staging/emxx_udc/emxx_udc.c b/drivers/staging/emxx_udc/emxx_udc.c > index 4178d96..f50bf5d 100644 > --- a/drivers/staging/emxx_udc/emxx_udc.c > +++ b/drivers/staging/emxx_udc/emxx_udc.c > @@ -3203,7 +3203,8 @@ static void __init nbu2ss_drv_ep_init(struct nbu2ss_udc *udc) > ep->ep.name = gp_ep_name[i]; > ep->ep.ops = &nbu2ss_ep_ops; > > - ep->ep.maxpacket = (i == 0 ? EP0_PACKETSIZE : EP_PACKETSIZE); > + usb_ep_set_maxpacket_limit(&ep->ep, > + (i == 0 ? EP0_PACKETSIZE : EP_PACKETSIZE)); Inner () not needed. [...] WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/