Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757536AbbGGOna (ORCPT ); Tue, 7 Jul 2015 10:43:30 -0400 Received: from metis.ext.pengutronix.de ([92.198.50.35]:37677 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757254AbbGGOnX (ORCPT ); Tue, 7 Jul 2015 10:43:23 -0400 Subject: Re: [PATCH 1/2] net: can: c_can: Fix default pinmux glitch at init To: Roger Quadros , wg@grandegger.com, tony@atomide.com References: <1436279277-3386-1-git-send-email-rogerq@ti.com> <1436279277-3386-2-git-send-email-rogerq@ti.com> <559BE34F.8080508@pengutronix.de> <559BE3BE.2020608@ti.com> <559BE433.9020308@ti.com> Cc: jay.schroeder@garmin.com, linux-can@vger.kernel.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org From: Marc Kleine-Budde Message-ID: <559BE579.2020109@pengutronix.de> Date: Tue, 7 Jul 2015 16:43:05 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.0 MIME-Version: 1.0 In-Reply-To: <559BE433.9020308@ti.com> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Nn1rnQlbGDrUM2QoIMK8BmMIUEIrHfrFl" X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2222 Lines: 64 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Nn1rnQlbGDrUM2QoIMK8BmMIUEIrHfrFl Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 07/07/2015 04:37 PM, Roger Quadros wrote: >>>> diff --git a/drivers/net/can/c_can/c_can.c >>>> b/drivers/net/can/c_can/c_can.c >>>> index 041525d..66e98e7 100644 >>>> --- a/drivers/net/can/c_can/c_can.c >>>> +++ b/drivers/net/can/c_can/c_can.c >>>> @@ -605,7 +605,18 @@ static int c_can_start(struct net_device *dev) >>>> priv->can.state =3D CAN_STATE_ERROR_ACTIVE; >>>> >>>> /* activate pins */ >>>> - pinctrl_pm_select_default_state(dev->dev.parent); >>>> +#ifdef CONFIG_PINCTRL >>> >>> Please remove the ifdef, AFAICS there are static inline noop function= s >>> if CONFIG_PINCTRL switched off. >> >> yes, you are right. >=20 > On second thoughts >=20 > device->pins are not defined if CONFIG_PINCTRL is not set. > so we can't remove the #ifdef. Too bad :( okay - should I add stable@v.k.o on Cc? Marc --=20 Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | --Nn1rnQlbGDrUM2QoIMK8BmMIUEIrHfrFl Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBCgAGBQJVm+V5AAoJEP5prqPJtc/HBxEIAJ4WIP0MQfzgygNgENNA3SYX SFszysMjsErA6GncYP66hPnKYP+rRJ3FrA8MWJxj8Z31ZM+K9+bXjl78BQFHslVu yduiCgKuHRTcmLITF2KjuGFDGM0faqVh4ZfSRHwhiQP8P7SFlk1MSxYjql9vIcTq V9sN6z17UYsL3mxUKHpv/G+t99x+oJgvlBrfziJtC5+IiO9BGdj4bVcHKsutuwxa SwjMGZcgUfzX/6mkMnK3/sWlIGHFfdNEVFBC7SFfzZuUf+nEWs3XyWzuxgRFXlPR ylDAGWPr98Ate4bGhvSRxXaI3We+1Xl6z2u3H498zbAJA5i7RRuxVGtTsRm5yc0= =DI7g -----END PGP SIGNATURE----- --Nn1rnQlbGDrUM2QoIMK8BmMIUEIrHfrFl-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/