Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757265AbbGGOzv (ORCPT ); Tue, 7 Jul 2015 10:55:51 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:36050 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757390AbbGGOyx (ORCPT ); Tue, 7 Jul 2015 10:54:53 -0400 Message-ID: <559BE807.2030802@ti.com> Date: Tue, 7 Jul 2015 17:53:59 +0300 From: Grygorii Strashko User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Wolfram Sang , =?UTF-8?B?VXdlIEtsZWluZS1Lw7ZuaWc=?= CC: =?UTF-8?B?SmFuIEzDvGJiZQ==?= , Sekhar Nori , , , , Mike Looijmans , Kevin Hilman , Santosh Shilimkar , Murali Karicheri , Subject: Re: [PATCH v2 5/5] i2c: davinci: use ICPFUNC to toggle I2C as gpio for bus recovery References: <1417010393-30598-1-git-send-email-grygorii.strashko@ti.com> <1417010393-30598-6-git-send-email-grygorii.strashko@ti.com> <20141126160407.GN4431@pengutronix.de> <5476085B.40009@ti.com> <1436276269.3344.94.camel@pengutronix.de> <20150707134852.GE9671@pengutronix.de> <20150707141312.GC3411@katana> In-Reply-To: <20150707141312.GC3411@katana> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3010 Lines: 63 On 07/07/2015 05:13 PM, Wolfram Sang wrote: > On Tue, Jul 07, 2015 at 03:48:52PM +0200, Uwe Kleine-König wrote: >> On Tue, Jul 07, 2015 at 03:37:49PM +0200, Jan Lübbe wrote: >>> On Mi, 2014-11-26 at 19:05 +0200, Grygorii Strashko wrote: >>>> On 11/26/2014 06:04 PM, Uwe Kleine-König wrote: >>>>> On Wed, Nov 26, 2014 at 03:59:53PM +0200, Grygorii Strashko wrote: >>>>>> Having a board where the I2C bus locks up occasionally made it clear >>>>>> that the bus recovery in the i2c-davinci driver will only work on >>>>>> some boards, because on regular boards, this will only toggle GPIO >>>>>> lines that aren't muxed to the actual pins. >>>>>> >>>>>> The I2C controller on SoCs like da850 (and da830), Keystone 2 has the >>>>>> built-in capability to bit-bang its lines by using the ICPFUNC registers >>>>>> of the i2c controller. >>>>>> Implement the suggested procedure by toggling SCL and checking SDA using >>>>>> the ICPFUNC registers of the I2C controller when present. Allow platforms >>>>>> to indicate the presence of the ICPFUNC registers with a has_pfunc platform >>>>>> data flag and add optional DT property "ti,has-pfunc" to indicate >>>>>> the same in DT. >>>>> On what does it depend if this pfunc stuff works or not? Only the SoC, >>>>> or also on some board specific properties? >>>> >>>> SoC / set of SoCs. Also, similar feature is supported by OMAP and AM335x/AM437x SoCs >>>> using I2C_SYSTEST register. >>>> >>>>> Given the former using the >>>>> compatible string to detect its availability would be better. (In this >>>>> case also sorry, didn't consider this case when requesting the property >>>>> in the last round.) >>> >>> I only stumbled across this after it was merged, with the additional >> I also wonder how it came to the Reviewed-by tag for me. The last thing >> that I said about the patch was "On what does it depend if this pfunc >> stuff works or not? Only the SoC, or also on some board specific >> properties?" (see above) and "the patch looks ok". IMHO this hardly >> justifies to add the Reviewed-by tag for the next round. :-( > > That needs to be discussed with Grygorii. I can't verify the correctness > of tags for every patch, although I do try to keep an eye on it... > Regarding "the patch looks ok" - sincerely sorry! This is not the first time I've treated "looks good.." as Reviewed-by and I got no complaints before :( Will take it into account. Regarding technical comments: OK. Seems I missed smth. or understood wrongly. So, I'll say what's people usually saying here - Sorry for that :( But, to be honest I don't feel guilty, because: - v4 of these patches was merged finally - that v4 missed >2 kernel releases - you were added in "TO:" for all versions of these patches. -- regards, -grygorii -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/