Subject: Re: [PATCH 1/4] KVM: count number of assigned devices
To: Alex Williamson <alex.williamson@redhat.com>
References: <1436276739-50326-1-git-send-email-pbonzini@redhat.com>
 <1436276739-50326-2-git-send-email-pbonzini@redhat.com>
 <1436282525.1391.42.camel@redhat.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
        guangrong.xiao@linux.intel.com, jroedel@suse.de, ogerlitz@mellanox.com,
        amirv@mellanox.com
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <559BF203.2010202@redhat.com>
Date: Tue, 7 Jul 2015 17:36:35 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.0.1
MIME-Version: 1.0
In-Reply-To: <1436282525.1391.42.camel@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 841
Lines: 20


On 07/07/2015 17:22, Alex Williamson wrote:
>> > -#define __KVM_HAVE_ARCH_NONCOHERENT_DMA
>> > +#define __KVM_HAVE_ARCH_VFIO_HOOKS
> Do we really want to tie these two things together under something
> that's not strictly a "vfio" option?  Legacy assignment also makes use
> of these, as shown in this patch, but even if we consider that temporary
> until legacy assignment is removed, I can imagine platforms that might
> care about one but not the other.  I don't really see the harm in using
> a separate #define, perhaps __KVM_HAVE_ARCH_ASSIGNED_DEVICE.  Thanks,

Sure, that's okay.

Paolo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/