Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932469AbbGGP6r (ORCPT ); Tue, 7 Jul 2015 11:58:47 -0400 Received: from smtprelay0082.hostedemail.com ([216.40.44.82]:46377 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932440AbbGGP6h (ORCPT ); Tue, 7 Jul 2015 11:58:37 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2693:2902:3138:3139:3140:3141:3142:3353:3622:3865:3866:3867:3870:3871:3872:4321:4384:5007:6120:6261:7875:10004:10400:10848:10967:11026:11232:11473:11658:11914:12043:12296:12438:12517:12519:12555:12740:13069:13311:13357:14096:14097:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: bag02_67e733d45042c X-Filterd-Recvd-Size: 2693 Date: Tue, 7 Jul 2015 11:58:33 -0400 From: Steven Rostedt To: Chunyan Zhang Cc: mingo@redhat.com, mathieu.poirier@linaro.org, serge.broslavsky@linaro.org, broonie@kernel.org, alexander.shishkin@linux.intel.com, zhang.lyra@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH v3 2/4] trace: Add an entry for printing trace log to STM Message-ID: <20150707115833.7bb1e613@gandalf.local.home> In-Reply-To: References: X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.28; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1794 Lines: 56 On Tue, 7 Jul 2015 18:10:41 +0800 Chunyan Zhang wrote: > output_stm is a link which is used to connect trace event > logging with STMs, will be used in the upcoming patches. > > Signed-off-by: Chunyan Zhang > --- > include/linux/trace_events.h | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/include/linux/trace_events.h b/include/linux/trace_events.h > index 1063c85..28dcdff 100644 > --- a/include/linux/trace_events.h > +++ b/include/linux/trace_events.h > @@ -14,6 +14,7 @@ struct trace_buffer; > struct tracer; > struct dentry; > struct bpf_prog; > +struct trace_buffer_stm; > > struct trace_print_flags { > unsigned long mask; > @@ -293,6 +294,9 @@ struct trace_event_call { > */ > int flags; /* static flags of different events */ > > + void (*output_stm)(struct trace_seq *tmp_seq, void *entry, > + struct trace_buffer_stm *tb); > + Shouldn't the above also have a #ifdef CONFIG_STM_TRACE_EVENT encompassing it? Otherwise we are adding 8 bytes to every trace event. -- Steve > #ifdef CONFIG_PERF_EVENTS > int perf_refcount; > struct hlist_head __percpu *perf_events; > @@ -412,6 +416,10 @@ enum event_trigger_type { > ETT_EVENT_ENABLE = (1 << 3), > }; > > +#ifdef CONFIG_STM_TRACE_EVENT > +extern void stm_trace_event_write(const char *buf, unsigned len); > +#endif > + > extern int filter_match_preds(struct event_filter *filter, void *rec); > > extern int filter_check_discard(struct trace_event_file *file, void *rec, -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/