Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757822AbbGGQOH (ORCPT ); Tue, 7 Jul 2015 12:14:07 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:35535 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757509AbbGGQOD (ORCPT ); Tue, 7 Jul 2015 12:14:03 -0400 Date: Tue, 7 Jul 2015 18:07:44 +0200 From: Andrew Lunn To: Vivien Didelot Cc: netdev , David , Scott Feldman , Jiri Pirko , Florian Fainelli , Guenter Roeck , linux-kernel , kernel Subject: Re: [PATCH v3 1/3] net: dsa: mv88e6xxx: add debugfs interface for VTU Message-ID: <20150707160744.GA13230@lunn.ch> References: <1436148893-14379-1-git-send-email-vivien.didelot@savoirfairelinux.com> <1436148893-14379-2-git-send-email-vivien.didelot@savoirfairelinux.com> <20150707020818.GB5540@lunn.ch> <1165322565.210276.1436284349938.JavaMail.zimbra@savoirfairelinux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1165322565.210276.1436284349938.JavaMail.zimbra@savoirfairelinux.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 884 Lines: 18 > Indeed, I intentionally kept it as is, since the 88E6352 datasheet is not > really clear about this. I see that the register 0x09 (called > GLOBAL_VTU_DATA_8_11 in mv88e6xxx.h) only contains VID priority related bits in > 15:12, in my case. As bits 11:0 are reserved, I suspect that the offsets of > Member TagP7, Member TagP8 and Member TagP9 are respectively 0, 4 and 8 for > you. Can you confirm? If so, I'll make that generic with these values. Yes, the pattern continues for up to 11 ports, if you look at the DSDT sources from Marvell. The mv88e6131.c driver has one device, the 6095, with 11 ports. Thanks Andrew -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/