Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932242AbbGGQTm (ORCPT ); Tue, 7 Jul 2015 12:19:42 -0400 Received: from mail.savoirfairelinux.com ([209.172.62.77]:50711 "EHLO mail.savoirfairelinux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751688AbbGGQTd (ORCPT ); Tue, 7 Jul 2015 12:19:33 -0400 Date: Tue, 7 Jul 2015 12:19:29 -0400 (EDT) From: Vivien Didelot To: Andrew Lunn , Guenter Roeck Cc: netdev , David , Scott Feldman , Jiri Pirko , Florian Fainelli , linux-kernel , kernel Message-ID: <1021310176.218025.1436285969810.JavaMail.zimbra@savoirfairelinux.com> In-Reply-To: <20150707160744.GA13230@lunn.ch> References: <1436148893-14379-1-git-send-email-vivien.didelot@savoirfairelinux.com> <1436148893-14379-2-git-send-email-vivien.didelot@savoirfairelinux.com> <20150707020818.GB5540@lunn.ch> <1165322565.210276.1436284349938.JavaMail.zimbra@savoirfairelinux.com> <20150707160744.GA13230@lunn.ch> Subject: Re: [PATCH v3 1/3] net: dsa: mv88e6xxx: add debugfs interface for VTU MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Mailer: Zimbra 8.6.0_GA_1153 (ZimbraWebClient - FF38 (Linux)/8.6.0_GA_1153) Thread-Topic: mv88e6xxx: add debugfs interface for VTU Thread-Index: TRaz8IXLUyjjvKoRXaixtLb1gl+03g== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1032 Lines: 24 Hi Guenter, Andrew, ----- On Jul 7, 2015, at 12:07 PM, Andrew Lunn andrew@lunn.ch wrote: >> Indeed, I intentionally kept it as is, since the 88E6352 datasheet is not >> really clear about this. I see that the register 0x09 (called >> GLOBAL_VTU_DATA_8_11 in mv88e6xxx.h) only contains VID priority related bits in >> 15:12, in my case. As bits 11:0 are reserved, I suspect that the offsets of >> Member TagP7, Member TagP8 and Member TagP9 are respectively 0, 4 and 8 for >> you. Can you confirm? If so, I'll make that generic with these values. > > Yes, the pattern continues for up to 11 ports, if you look at the DSDT > sources from Marvell. The mv88e6131.c driver has one device, the 6095, > with 11 ports. Thanks for the details. I make the change and send a v4 asap. Best, -v -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/