Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932357AbbGGQYs (ORCPT ); Tue, 7 Jul 2015 12:24:48 -0400 Received: from sender163-mail.zoho.com ([74.201.84.163]:25490 "EHLO sender163-mail.zoho.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757636AbbGGQYj (ORCPT ); Tue, 7 Jul 2015 12:24:39 -0400 X-Greylist: delayed 1438 seconds by postgrey-1.27 at vger.kernel.org; Tue, 07 Jul 2015 12:24:39 EDT Message-ID: <559BFD3E.6040609@hackerion.com> Date: Tue, 07 Jul 2015 18:24:30 +0200 From: Robert Baldyga User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Dan Carpenter , Robert Baldyga CC: gregkh@linuxfoundation.org, balbi@ti.com, devel@driverdev.osuosl.org, hamohammed.sa@gmail.com, chris@rorvick.com, tapaswenipathak@gmail.com, linux-usb@vger.kernel.org, nicolas.ferre@atmel.com, hgujulan@visteon.com, mina86@mina86.com, linux-kernel@vger.kernel.org, vinc94@gmail.com, roberta.dobrescu@gmail.com, andrzej.p@samsung.com, linux-arm-kernel@lists.infradead.org, m.szyprowski@samsung.com Subject: Re: [PATCH 3/5] usb: isp1760: udc: add missing usb_ep_set_maxpacket_limit() References: <1436277773-14274-1-git-send-email-r.baldyga@samsung.com> <1436277773-14274-4-git-send-email-r.baldyga@samsung.com> <20150707150156.GE4341@mwanda> In-Reply-To: <20150707150156.GE4341@mwanda> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1963 Lines: 51 On 07/07/2015 05:01 PM, Dan Carpenter wrote: > On Tue, Jul 07, 2015 at 04:02:51PM +0200, Robert Baldyga wrote: >> Should use usb_ep_set_maxpacket_limit instead of setting >> maxpacket value manually. >> > > This is a behavior change, right, since now we're setting > ep->ep.maxpacket and ep->ep.maxpacket_limit where before we only set > the first. I don't understand. This patch description is not clear. Since maxpacket_limit was introduced all UDC drivers should set it, as it is used by epautoconf. The ep.maxpacket_limit contains actual maximum maxpacket value supported by hardware, ep.maxpacket is set only for backward compatibility. Hence setting maxpacket manually instead of using usb_ep_set_maxpacket_limit() is actually a bug. I will add better description to commit message. > >> Signed-off-by: Robert Baldyga >> --- >> drivers/usb/isp1760/isp1760-udc.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/usb/isp1760/isp1760-udc.c b/drivers/usb/isp1760/isp1760-udc.c >> index 18ebf5b1..3699962 100644 >> --- a/drivers/usb/isp1760/isp1760-udc.c >> +++ b/drivers/usb/isp1760/isp1760-udc.c >> @@ -1382,11 +1382,11 @@ static void isp1760_udc_init_eps(struct isp1760_udc *udc) >> * This fits in the 8kB FIFO without double-buffering. >> */ >> if (ep_num == 0) { >> - ep->ep.maxpacket = 64; >> + usb_ep_set_maxpacket_limit(&ep->ep, 64); >> ep->maxpacket = 64; >> udc->gadget.ep0 = &ep->ep; >> } else { >> - ep->ep.maxpacket = 512; >> + usb_ep_set_maxpacket_limit(&ep->ep, 512); >> ep->maxpacket = 0; >> list_add_tail(&ep->ep.ep_list, &udc->gadget.ep_list); >> } Thanks, Robert Baldyga -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/