Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757952AbbGGQrF (ORCPT ); Tue, 7 Jul 2015 12:47:05 -0400 Received: from mail.codeweavers.com ([216.251.189.131]:40929 "EHLO mail.codeweavers.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757482AbbGGQrD (ORCPT ); Tue, 7 Jul 2015 12:47:03 -0400 Message-ID: <559C0285.6090509@codeweavers.com> Date: Tue, 07 Jul 2015 11:47:01 -0500 From: Jeremy White User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.7.0 MIME-Version: 1.0 To: Greg KH CC: hdegoede@redhat.com, spice-devel@lists.freedesktop.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 1/1] Add a usbredir kernel module to remotely connect USB devices over IP. References: <1435700650-640-1-git-send-email-jwhite@codeweavers.com> <1435700650-640-2-git-send-email-jwhite@codeweavers.com> <20150630234805.GB13573@kroah.com> <55935FC1.8090203@codeweavers.com> <20150701054416.GA23370@kroah.com> <55940D85.9030702@codeweavers.com> <20150701161342.GB31389@kroah.com> In-Reply-To: <20150701161342.GB31389@kroah.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1949 Lines: 45 >> >> Well, the checkpatch.pl reports were all style (and mostly whitespace); >> roughly 3000 of them against 3000 lines of code :-/. I did review the >> code, looking for areas where I thought it would badly cram into the >> kernel, and I adjusted the few I found (and sent changes upstream). > > style matters, as it's a thing with your brain. You learn patterns and > if the patterns change, you have to do more work and don't see the real > issues involved. So by ignoring our style you are saying you don't want > anyone else in the kernel community to ever review or work on the code, > which isn't ok. Looks like I can't side step this unless Hans is willing to shift the usbredir project entirely to using kernel style :-/. I will plan to make changes so that checkpatch runs clean; I lay out my concerns and my plan below to make sure I'm taking the best path. My main concern with changing the ~2,500 lines of code from the upstream usbredir project is that it will increase the odds that I will introduce errors, both initially, and again later as I review and attempt to relay patches from the upstream. To summarize the checkpatch reports: the biggest issue is whitespace, which shouldn't be a problem; I should be able to automate that without error. There are also a fair number of one offs; FSF address, space after '!', etc. I hope to persuade Hans to take a few style only patches upstream to address those. That leaves a pack of about 60 brace placement and line length issues. I will plan to manually change those prior to submission. Any upstream changes that affect the same code will be manually corrected as well, prior to submission. Make sense? Cheers, Jeremy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/