DomainKey-Signature: s=smtpout; d=dell.com; c=nofws; q=dns;
  h=X-LoopCount0:X-IronPort-AV:Message-ID:Date:From:
   Organization:User-Agent:MIME-Version:To:CC:Subject:
   References:In-Reply-To:Content-Type:
   Content-Transfer-Encoding;
  b=eH9lB1dAoxjKBpVuciMvTKRp1QNUwB+IMnafNpC48+bKQjzRhu1fuBuk
   UwOLlvZ8sxmU1YHJLy0e6JfBvd/QGTBAQRSeeVqtnYOgmD40u25RCUCYi
   lQJFKsWJfX5DUkcv+YzWxxnGLxGVYi+D3O+2hOrrbIAKLvIw60+SdYcIK
   Q=;
Message-ID: <559C1CB1.4040509@dell.com>
Date: Tue, 07 Jul 2015 13:38:41 -0500
From: Mario Limonciello <mario_limonciello@dell.com>
Organization: Dell Inc.
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: =?UTF-8?B?UGFsaSBSb2jDoXI=?= <pali.rohar@gmail.com>,
        Matthew Garrett <mjg@redhat.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Len Brown <len.brown@intel.com>,
        "platform-driver-x86@vger.kernel.org" 
	<platform-driver-x86@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC: Gabriele Mazzotta <gabriele.mzt@gmail.com>,
        =?UTF-8?B?TWljaGHFgiBLxJlw?= =?UTF-8?B?aWXFhA==?= 
	<kernel@kempniu.pl>
Subject: Re: BUG? Duplicate key code 0xe045 in dell-wmi.c
References: <201507041834.03944@pali>
In-Reply-To: <201507041834.03944@pali>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1825
Lines: 51


On 07/04/2015 11:34 AM, Pali Rohár wrote:
> Hello,
>
> I'm looking at dell-wmi.c driver and its history in git and I found 
> problem with handling WMI key code 0xe045. In current dell-wmi.c code is
>
> {KE_KEY, 0xe045, KEY_PROG1},
> {KE_IGNORE, 0xe045, KEY_NUMLOCK},
>
> I bet this is some copy-paste error as one code can be translated only 
> to one input key event.
>
> In git history I found that above change was added by commit:
>
> http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=5cab0098171712a9fd51399b06181c8dfdebe9c9
>
> ===============================================
> commit 5cab0098171712a9fd51399b06181c8dfdebe9c9
> Author: Mario Limonciello <mario_limonciello@dell.com>
> Date:   Wed Jun 10 19:40:47 2009 +0000
>
>     dell-wmi: add additional keyboard events
>     
>     Upcoming Dell hardware will send more keyboard events via WMI.  Add
>     support for them.
>     
>     Signed-off-by: Mario Limonciello <mario_limonciello@dell.com>
>     Signed-off-by: Matthew Garrett <mjg@redhat.com>
>     Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
>     Signed-off-by: Len Brown <len.brown@intel.com>
> ===============================================
>
> Sending email to all signers of this commit. Problematic code is still 
> in upstream kernel, so it needs to be fixed.
>
> Mario Limonciello: Do you know if code 0xe045 is some PROG1 or NUMLOCK?
>
Hi Pali,

Yes this looks like a mistake and that the KEY_PROG1 item should have
been removed in that patch.  It should be a notification (KEY_IGNORE)
for numlock.

Thanks,
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/