Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932789AbbGGTSx (ORCPT ); Tue, 7 Jul 2015 15:18:53 -0400 Received: from mail-pd0-f176.google.com ([209.85.192.176]:34969 "EHLO mail-pd0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932661AbbGGTSo (ORCPT ); Tue, 7 Jul 2015 15:18:44 -0400 Date: Tue, 7 Jul 2015 12:18:40 -0700 From: Alexei Starovoitov To: Vince Weaver Cc: Masami Hiramatsu , linux-kernel@vger.kernel.org, Ananth N Mavinakayanahalli , Anil S Keshavamurthy , "David S. Miller" , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Steven Rostedt Subject: Re: perf, kprobes: fuzzer generates huge number of WARNings Message-ID: <20150707191839.GB6040@Alexeis-MBP.westell.com> References: <559B3899.5040802@hitachi.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1055 Lines: 23 On Tue, Jul 07, 2015 at 12:00:12AM -0400, Vince Weaver wrote: > > Well the BPF hack is in the fuzzer, not the kernel. And it's not really a > hack, it just turned out to be a huge pain to figure out how to > manually create a valid BPF program in conjunction with a valid kprobe > event. You mean automatically generating valid bpf program? That's definitely hard. If you mean just few hardcoded programs then take them from samples or from test_bpf ? > I did have to sprinkle printks in the kprobe and bpf code to find out > where various EINVAL returns were coming from, so potentially this is just > a problem of printks happening where they shouldn't. I'll remove those > changes and try to reproduce this tomorrow. could you please elaborate on this further. Which EINVALs you talking about? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/