Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933191AbbGGTdO (ORCPT ); Tue, 7 Jul 2015 15:33:14 -0400 Received: from outbound.smtp.vt.edu ([198.82.183.121]:45225 "EHLO omr2.cc.vt.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932751AbbGGTdA (ORCPT ); Tue, 7 Jul 2015 15:33:00 -0400 X-Mailer: exmh version 2.8.0 04/21/2012 with nmh-1.6+dev To: Sreenath Madasu Cc: jteki@openedev.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Warnings : Fixed 80 character length warning in rtw_ap.c In-Reply-To: Your message of "Mon, 06 Jul 2015 21:53:26 -0400." <20150707015326.GA3075@sreenath-gentoo.lan> From: Valdis.Kletnieks@vt.edu References: <20150707015326.GA3075@sreenath-gentoo.lan> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="==_Exmh_1436297570_3004P"; micalg=pgp-sha1; protocol="application/pgp-signature" Content-Transfer-Encoding: 7bit Date: Tue, 07 Jul 2015 15:32:50 -0400 Message-ID: <15662.1436297570@turing-police.cc.vt.edu> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1941 Lines: 51 --==_Exmh_1436297570_3004P Content-Type: text/plain; charset=us-ascii On Mon, 06 Jul 2015 21:53:26 -0400, Sreenath Madasu said: > When the checkpatch.pl script was run, it showed lines with length > more than 80 characters in rtw_ap.c file. Fixed line number 382 by > breaking it up into two lines within 80 characters. > - stainfo_offset = rtw_stainfo_offset(pstapriv, psta); > + stainfo_offset = > + rtw_stainfo_offset(pstapriv, psta); > if (stainfo_offset_valid(stainfo_offset)) > chk_alive_list[chk_alive_num++] = stainfo_offset; Umm... Sreenath? There's 97 more occurrences of the same problem in that file. All: Is it time to kill that checkpatch test, or hide it behind a non-default flag, to prevent code churn? --==_Exmh_1436297570_3004P Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Exmh version 2.5 07/13/2001 iQIVAwUBVZwpYgdmEQWDXROgAQIBARAAqtK6yDK15VxP1IWZNyBRCqse7Wwsf3b7 /pZNRjaHEVwnUFebCom6ptea7xv3PhEx3v++8itmOB0nq7HHUKMIRSDCJW/kI/Kq ZEQNXyTPD1LVZjuovycsv8zwSvqedQBeehReG0OHukI9SbdNIHsDknV2gf+nFbmf itX9TAPsqZWNbKzYkxJbNAnh/TIR4Dt7mCyc+8sUrs3Fl0fU/TX5dimlPr0B7vqL cvPbxEFAV2B+czuarge/W4vkZLT/buXxmKMQxOEYRdZeqpdS9mc9ubljnjmL7Apr yJ7Vxok3Hlh/i31j1UULZg37Idin5JDe0ldq/4HKpk21UesAD2KutHFzLcL+biQX 8Ov/uNKy+GtIgLLUdcpTq6MAyC/XFBK+zAgQytB0yl7hHEYoylaFaRxdg8QvIGMp B2PS3H+py7WYiXc/NMx25zaq+c3o8cpWssMElX5GkvhDsVuEoCkiV/sb9aRgfaqf 1TcG40JoE+F4sTlS9X/wmKr7435i5qgZbwqhUJ3X+Pi/My+GNdc+binzk/okYTam TNeIr/pSrDJVrdqKhyJzhRQiD4TuhJfC+sjwSuJOs+U5kX6wPh14ypWi9OQFN961 GCvyoXdEGhLI381ZuM/nwERXNE1K7wmdotjpA1D309RM2wtY8fxNzhmPo3z/Akgc 9NhoLLaX4D8= =10in -----END PGP SIGNATURE----- --==_Exmh_1436297570_3004P-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/