Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S933266AbbGGUi6 (ORCPT <rfc822;w@1wt.eu>);
	Tue, 7 Jul 2015 16:38:58 -0400
Received: from smtprelay0094.hostedemail.com ([216.40.44.94]:40089 "EHLO
	smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
	by vger.kernel.org with ESMTP id S932745AbbGGUiv (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 7 Jul 2015 16:38:51 -0400
X-Session-Marker: 6A6F6540706572636865732E636F6D
X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:800:960:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:2898:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3870:3871:3872:3874:4321:5007:6119:6261:7903:10004:10400:10848:11232:11658:11914:12517:12519:12663:12740:13069:13161:13229:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0
X-HE-Tag: rule66_4cf3a23b76921
X-Filterd-Recvd-Size: 1527
Message-ID: <1436301527.2682.60.camel@perches.com>
Subject: Re: [PATCH] Warnings : Fixed 80 character length warning in rtw_ap.c
From: Joe Perches <joe@perches.com>
To: Valdis.Kletnieks@vt.edu
Cc: Sreenath Madasu <sreenath.madasu@gmail.com>, jteki@openedev.com,
        devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Date: Tue, 07 Jul 2015 13:38:47 -0700
In-Reply-To: <15662.1436297570@turing-police.cc.vt.edu>
References: <20150707015326.GA3075@sreenath-gentoo.lan>
	 <15662.1436297570@turing-police.cc.vt.edu>
Content-Type: text/plain; charset="ISO-8859-1"
X-Mailer: Evolution 3.12.11-0ubuntu3 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 861
Lines: 26

On Tue, 2015-07-07 at 15:32 -0400, Valdis.Kletnieks@vt.edu wrote:
> All:  Is it time to kill that checkpatch test, or hide it behind a non-default
> flag, to prevent code churn?

<shrug> I'm not an 80 column zealot.

This is for staging isn't it?
Code churn there is expected and somewhat desired.

A lot of time, code churn can be useful when it
reduces the indentation depth.

For instance, this code could use continue more.

The longest line in this file is 158 chars, that's
probably excessive,  awk shows 35 lines > 80 chars.

staging rtl files have a couple hundred lines > 132
and thousands of lines > 80.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/