Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933167AbbGGUtz (ORCPT ); Tue, 7 Jul 2015 16:49:55 -0400 Received: from mail.emea.novell.com ([130.57.118.101]:43409 "EHLO mail.emea.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932630AbbGGUtq (ORCPT ); Tue, 7 Jul 2015 16:49:46 -0400 Date: Tue, 7 Jul 2015 22:49:30 +0200 (CEST) From: Jiri Kosina X-X-Sender: jkosina@pobox.suse.cz To: Gabriele Mazzotta cc: benjamin.tissoires@redhat.com, aduggan@synaptics.com, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] HID: i2c-hid: Call device suspend callback before disabling irq In-Reply-To: <1436299082-3526-1-git-send-email-gabriele.mzt@gmail.com> Message-ID: References: <1436299082-3526-1-git-send-email-gabriele.mzt@gmail.com> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 795 Lines: 25 On Tue, 7 Jul 2015, Gabriele Mazzotta wrote: > The irq is most likely required by the suspend callback, so disable it > only after the callback had been executed. It would be nice to have a more verbose changelog here -- i.e. why we want to do such change and what could go wrong if IRQ is disabled too early (i.e. what bug is this exactly fixing). > > Signed-off-by: Gabriele Mazzotta I'd see this as a 4.2 material still. Please let me know if you'd rather want to wait for 4.3. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/