Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933249AbbGGUwQ (ORCPT ); Tue, 7 Jul 2015 16:52:16 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:32633 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932930AbbGGUwI (ORCPT ); Tue, 7 Jul 2015 16:52:08 -0400 Message-ID: <559C3BDE.8090103@oracle.com> Date: Tue, 07 Jul 2015 16:51:42 -0400 From: Boris Ostrovsky User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Konrad Rzeszutek Wilk CC: david.vrabel@citrix.com, roger.pau@citrix.com, elena.ufimtseva@oracle.com, stefano.stabellini@eu.citrix.com, tim@xen.org, jbeulich@suse.com, andrew.cooper3@citrix.com, ian.campbell@citrix.com, wei.liu2@citrix.com, ian.jackson@eu.citrix.com, xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/6] xen/x86/pvh: Save %rbx in xen_pvh_early_cpu_init() References: <1436240065-10813-1-git-send-email-boris.ostrovsky@oracle.com> <1436240065-10813-2-git-send-email-boris.ostrovsky@oracle.com> <20150707201626.GG6372@l.oracle.com> <20150707202615.GH6372@l.oracle.com> In-Reply-To: <20150707202615.GH6372@l.oracle.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1138 Lines: 31 On 07/07/2015 04:26 PM, Konrad Rzeszutek Wilk wrote: >>> diff --git a/arch/x86/xen/xen-head.S b/arch/x86/xen/xen-head.S >>> index 8afdfcc..b1508a8 100644 >>> --- a/arch/x86/xen/xen-head.S >>> +++ b/arch/x86/xen/xen-head.S >>> @@ -56,28 +56,28 @@ ENTRY(startup_xen) >>> * @entry: true if this is a secondary vcpu coming up on this entry >>> * point, false if this is the boot CPU being initialized for >>> * the first time (%rsi) >>> - * >>> - * Note: This is called as a function on the boot CPU, and is the entry point >>> - * on the secondary CPU. >>> */ >>> ENTRY(xen_pvh_early_cpu_init) >>> - mov %rsi, %r11 >>> + mov %rbx, -8(%rsp) >>> >>> +/* Entry point for secondary CPUs */ > Actually, could you do this (since the BSP can access the stack and > it can do jumps) - not compile tested: Yes, this looks better, I'll try it. Thanks. -boris -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/