Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933647AbbGGWnT (ORCPT ); Tue, 7 Jul 2015 18:43:19 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:43523 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933621AbbGGWnH (ORCPT ); Tue, 7 Jul 2015 18:43:07 -0400 Date: Tue, 7 Jul 2015 23:42:55 +0100 From: Mark Brown To: Sergej Sawazki Cc: gregkh@linuxfoundation.org, wsa@the-dreams.de, linux-kernel@vger.kernel.org Message-ID: <20150707224255.GK11162@sirena.org.uk> References: <557C2E3E.80000@gmx.de> <20150615094922.GB18309@sirena.org.uk> <20150615144933.GO18309@sirena.org.uk> <558B17F7.8070401@gmx.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="uVnQoIow9AuRQRua" Content-Disposition: inline In-Reply-To: <558B17F7.8070401@gmx.de> X-Cookie: Stay together, drag each other down. User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [BUG ?] regmap: debugfs: WARN_ON at regmap-debugfs.c:151 X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1780 Lines: 46 --uVnQoIow9AuRQRua Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Jun 24, 2015 at 10:49:59PM +0200, Sergej Sawazki wrote: > On Mon, 15 Jun 2015 15:49:33 +0100, Mark Brown wrote: > >Are you *sure* there are physically readable registers on the device? > >It's difficult to implement for 7x9 devices given that the top register > >bit is in the byte used to send the register address, I expect you'll > >find that the registers marked as readable are actually those that > >should be cached. > You are right, the registers are not physically readable. Sorry for the > confusion. > What I actually was trying to do is to read the cached register values. OK, so what we need to do here is rearrange things so we check the cache before we check for readability. That way if there is a cached value then we'll return it and the readability check will still reflect the hardware state. --uVnQoIow9AuRQRua Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVnFXuAAoJECTWi3JdVIfQSW8H/j3+N9Dj2e6vp8zioeurNoVI sNKD/sfcvmz9Ftfy/aqomkTWi+sPCZz8Ik7kh9xHam+jvGZBVnY+8txV9csQrb/W 9YVxiF5VcxfaxUGtUOMgNsj5BszihJWrlFOXLBlePo2t4WknHn+kdjEW38ccCGae UDkFBO+ENgMjDc2NMIGERNzejAwQ7oq0vYnhq8t5Ih4IZpSvwwFLmjPjosZm+iUo DuQgqYpwDmKZ4TR2aqkzWjWcx/62+2Xx3O6ykx0E0iTv75+RdxMMimVFKLYDCh++ q4Tb2CWHZGkamD+SHZG8SRypmOWlLkA8uOcoFIHJQDW0YO3SxjW0hMrj8m/9kS8= =RehO -----END PGP SIGNATURE----- --uVnQoIow9AuRQRua-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/