Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932547AbbGGXO4 (ORCPT ); Tue, 7 Jul 2015 19:14:56 -0400 Received: from mail-ig0-f176.google.com ([209.85.213.176]:35211 "EHLO mail-ig0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752614AbbGGXOs (ORCPT ); Tue, 7 Jul 2015 19:14:48 -0400 MIME-Version: 1.0 In-Reply-To: <1436300428-21163-27-git-send-email-yinghai@kernel.org> References: <1436300428-21163-1-git-send-email-yinghai@kernel.org> <1436300428-21163-27-git-send-email-yinghai@kernel.org> Date: Tue, 7 Jul 2015 16:14:48 -0700 X-Google-Sender-Auth: PTsmJAnlBBrDyfy_YPf7GSKdYjY Message-ID: Subject: Re: [PATCH 26/42] x86: remove not needed clear_page calling From: Kees Cook To: Yinghai Lu Cc: "H. Peter Anvin" , Baoquan He , LKML Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1406 Lines: 45 On Tue, Jul 7, 2015 at 1:20 PM, Yinghai Lu wrote: > remove not needed clear_page for init_level4_page in x86_64_start_kernel(), > as it is with fill 512,8,0 already in head_64.S Will all possible entry points have come through head_64.S? -Kees > > Signed-off-by: Yinghai Lu > --- > arch/x86/kernel/head64.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/x86/kernel/head64.c b/arch/x86/kernel/head64.c > index 44dc63b..a9f0299 100644 > --- a/arch/x86/kernel/head64.c > +++ b/arch/x86/kernel/head64.c > @@ -178,7 +178,6 @@ asmlinkage __visible void __init x86_64_start_kernel(char * real_mode_data) > */ > load_ucode_bsp(); > > - clear_page(init_level4_pgt); > /* set init_level4_pgt kernel high mapping*/ > init_level4_pgt[511] = early_level4_pgt[511]; > > -- > 1.8.4.5 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- Kees Cook Chrome OS Security -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/