Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757875AbbGHBEr (ORCPT ); Tue, 7 Jul 2015 21:04:47 -0400 Received: from kirsty.vergenet.net ([202.4.237.240]:34691 "EHLO kirsty.vergenet.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757311AbbGHBEj (ORCPT ); Tue, 7 Jul 2015 21:04:39 -0400 Date: Wed, 8 Jul 2015 10:04:35 +0900 From: Simon Horman To: Rob Herring Cc: Russell King , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "arm@kernel.org" , Magnus Damm , SH-Linux Subject: Re: [PATCH 12/15] SH: kill off set_irq_flags usage Message-ID: <20150708010435.GB28100@verge.net.au> References: <1433874401-27161-1-git-send-email-robh@kernel.org> <1433874401-27161-13-git-send-email-robh@kernel.org> <20150707005338.GG13326@verge.net.au> <20150707015503.GA23941@verge.net.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organisation: Horms Solutions Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3396 Lines: 86 On Tue, Jul 07, 2015 at 09:38:53AM -0500, Rob Herring wrote: > On Mon, Jul 6, 2015 at 8:55 PM, Simon Horman wrote: > > On Tue, Jul 07, 2015 at 09:53:39AM +0900, Simon Horman wrote: > >> On Tue, Jun 09, 2015 at 01:26:38PM -0500, Rob Herring wrote: > >> > set_irq_flags is ARM specific with custom flags which have genirq > >> > equivalents. Convert drivers to use the genirq interfaces directly, so we > >> > can kill off set_irq_flags. The translation of flags is as follows: > >> > > >> > IRQF_VALID -> !IRQ_NOREQUEST > >> > IRQF_PROBE -> !IRQ_NOPROBE > >> > IRQF_NOAUTOEN -> IRQ_NOAUTOEN > >> > > >> > For IRQs managed by an irqdomain, the irqdomain core code handles clearing > >> > and setting IRQ_NOREQUEST already, so there is no need to do this in > >> > .map() functions and we can simply remove the set_irq_flags calls. Some > >> > users also set IRQ_NOPROBE and this has been maintained although it is not > >> > clear that is really needed. There appears to be a great deal of blind > >> > copy and paste of this code. > >> > > >> > Signed-off-by: Rob Herring > >> > Cc: Simon Horman > >> > Cc: Magnus Damm > >> > Cc: linux-sh@vger.kernel.org > >> > >> I am trusting the description above coupled with the comments in > >> the original code (that this patch removes). Assuming those ducks are > >> aligned: > >> > >> Acked-by: Simon Horman > > > > As I usually take patches for drivers/sh/ (there have not been many of late) > > please let me know if you would like me to pick up this change. > > This is a dependency for removing set_irq_flags from ARM, so I plan to > send the whole series to arm-soc. Thanks, that is fine by me. > > Also, a very minor nit, the prefix for patches to this file is usually > > 'sh:' rather than 'SH:'. > > Okay, will fix-up. > > Rob > > > > >> > >> > --- > >> > drivers/sh/intc/internals.h | 10 +--------- > >> > 1 file changed, 1 insertion(+), 9 deletions(-) > >> > > >> > diff --git a/drivers/sh/intc/internals.h b/drivers/sh/intc/internals.h > >> > index 7dff08e..897ffb1 100644 > >> > --- a/drivers/sh/intc/internals.h > >> > +++ b/drivers/sh/intc/internals.h > >> > @@ -99,15 +99,7 @@ static inline struct intc_desc_int *get_intc_desc(unsigned int irq) > >> > */ > >> > static inline void activate_irq(int irq) > >> > { > >> > -#ifdef CONFIG_ARM > >> > - /* ARM requires an extra step to clear IRQ_NOREQUEST, which it > >> > - * sets on behalf of every irq_chip. Also sets IRQ_NOPROBE. > >> > - */ > >> > - set_irq_flags(irq, IRQF_VALID); > >> > -#else > >> > - /* same effect on other architectures */ > >> > - irq_set_noprobe(irq); > >> > -#endif > >> > + irq_clear_status_flags(irq, IRQ_NOREQUEST | IRQ_NOPROBE); > >> > } > >> > > >> > static inline int intc_handle_int_cmp(const void *a, const void *b) > >> > -- > >> > 2.1.0 > >> > > >> -- > >> To unsubscribe from this list: send the line "unsubscribe linux-sh" in > >> the body of a message to majordomo@vger.kernel.org > >> More majordomo info at http://vger.kernel.org/majordomo-info.html > >> > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/