Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757438AbbGHBIg (ORCPT ); Tue, 7 Jul 2015 21:08:36 -0400 Received: from mail-qg0-f53.google.com ([209.85.192.53]:34055 "EHLO mail-qg0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754184AbbGHBI2 (ORCPT ); Tue, 7 Jul 2015 21:08:28 -0400 From: Sreenath Madasu X-Google-Original-From: Sreenath Madasu Date: Tue, 7 Jul 2015 21:08:10 -0400 To: Valdis.Kletnieks@vt.edu Cc: jteki@openedev.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Warnings : Fixed 80 character length warning in rtw_ap.c Message-ID: <20150708010810.GA2563@sreenath-gentoo.lan> References: <20150707015326.GA3075@sreenath-gentoo.lan> <15662.1436297570@turing-police.cc.vt.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <15662.1436297570@turing-police.cc.vt.edu> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1177 Lines: 32 The kernelnewbies.org guide said "For your first patch, only pick one warning". That is the reason why I fixed one warning. Thanks Sreenath On Tue, Jul 07, 2015 at 03:32:50PM -0400, Valdis.Kletnieks@vt.edu wrote: > On Mon, 06 Jul 2015 21:53:26 -0400, Sreenath Madasu said: > > When the checkpatch.pl script was run, it showed lines with length > > more than 80 characters in rtw_ap.c file. Fixed line number 382 by > > breaking it up into two lines within 80 characters. > > > > - stainfo_offset = rtw_stainfo_offset(pstapriv, psta); > > + stainfo_offset = > > + rtw_stainfo_offset(pstapriv, psta); > > if (stainfo_offset_valid(stainfo_offset)) > > chk_alive_list[chk_alive_num++] = stainfo_offset; > > Umm... Sreenath? > > There's 97 more occurrences of the same problem in that file. > > All: Is it time to kill that checkpatch test, or hide it behind a non-default > flag, to prevent code churn? > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/