Date: Wed, 08 Jul 2015 04:23:34 +0000 (GMT)
From: Maninder Singh <maninder1.s@samsung.com>
Subject: Re: [PATCH 1/1] infiniband: Remove redundant NULL check before kfree
To: Doug Ledford <dledford@redhat.com>
Cc: Sean Hefty <sean.hefty@intel.com>, Or Gerlitz <ogerlitz@mellanox.com>,
        David Miller <davem@davemloft.net>,
        "roland@purestorage.com" <roland@purestorage.com>,
        Matan Barak <matanb@mellanox.com>, Moni Shoua <monis@mellanox.com>,
        "jackm@dev.mellanox.co.il" <jackm@dev.mellanox.co.il>,
        Yishai Hadas <yishaih@mellanox.com>,
        "eranbe@mellanox.com" <eranbe@mellanox.com>,
        Ira Weiny <ira.weiny@intel.com>,
        linux-rdma <linux-rdma@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        PANKAJ MISHRA <pankaj.m@samsung.com>
Reply-to: maninder1.s@samsung.com
MIME-version: 1.0
Msgkey: 20150708041407835@maninder1.s
Content-type: text/plain; charset=windows-1252
MIME-version: 1.0
Message-id: <1037392254.437811436329408244.JavaMail.weblogic@ep2mlwas06a>
DLP-Filter: Pass
Sender: linux-kernel-owner@vger.kernel.org
Content-Transfer-Encoding: 8bit
Content-Length: 992
Lines: 35

Hello,

>> +			for (i = 0; i < dev->caps.num_ports; i++)
>> +				kfree(dm[i]);
>> 			goto out;
>> 		}
>> 	}
>> --
>> 1.7.9.5
>> 
>
>If you are going to change this, you might as well make it 100% correct:
>
>i?-;
>while (i >= 0)
>	kfree(dm[i]);
>
>Then you don?t have to worry about whether kfree works on NULL, every item you free will be guaranteed to be non-NULL.
Thanks for suggestion :)
Sent new patch with described changes, I was thinking one more thing.

In below code :-
        if (!ibdev->sriov.is_going_down)
            queue_work(ibdev->sriov.demux[i].ud_wq, &dm[i]->work);
        spin_unlock_irqrestore(&ibdev->sriov.going_down_lock, flags);
    }
out:
    kfree(dm);
    return;

dm is freed after queue_work, is it correct to free dm when other dm[i] are allocated ? i did not get it.

Thanks
Maninder
------------????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m????????????I?