Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753993AbbGHFyJ (ORCPT ); Wed, 8 Jul 2015 01:54:09 -0400 Received: from mail-pd0-f176.google.com ([209.85.192.176]:33902 "EHLO mail-pd0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751536AbbGHFyE (ORCPT ); Wed, 8 Jul 2015 01:54:04 -0400 From: Viresh Kumar To: Rafael Wysocki Cc: linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org, Viresh Kumar , Pi-Cheng Chen , "Jon Medhurst (Tixy)" , linux-kernel@vger.kernel.org (open list) Subject: [PATCH] cpufreq: Initialize the governor again while restoring policy Date: Wed, 8 Jul 2015 11:23:58 +0530 Message-Id: X-Mailer: git-send-email 2.4.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1459 Lines: 40 When all CPUs of a policy are hot-unplugged, we EXIT the governor but don't mark policy->governor as NULL. This was done in order to keep last used governor's information intact in sysfs, while the CPUs are offline. We also missed marking policy->governor as NULL while restoring the policy. Because of that, we call __cpufreq_governor(CPUFREQ_GOV_LIMITS) for an uninitialized policy. Which eventually returns -EBUSY. Fix this by setting policy->governor to NULL while restoring the policy. Reported-by: Pi-Cheng Chen Reported-by: "Jon Medhurst (Tixy)" Fixes: 18bf3a124ef8 ("cpufreq: Mark policy->governor = NULL for inactive policies") Signed-off-by: Viresh Kumar --- For 4.2-rc drivers/cpufreq/cpufreq.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c index b612411655f9..2c22e3902e72 100644 --- a/drivers/cpufreq/cpufreq.c +++ b/drivers/cpufreq/cpufreq.c @@ -1132,6 +1132,7 @@ static struct cpufreq_policy *cpufreq_policy_restore(unsigned int cpu) down_write(&policy->rwsem); policy->cpu = cpu; + policy->governor = NULL; up_write(&policy->rwsem); } -- 2.4.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/