Subject: Re: [RFC PATCH 1/1] Add a usbredir kernel module to remotely connect
 USB devices over IP.
To: Jeremy White <jwhite@codeweavers.com>, Greg KH <greg@kroah.com>
References: <1435700650-640-1-git-send-email-jwhite@codeweavers.com>
 <1435700650-640-2-git-send-email-jwhite@codeweavers.com>
 <20150630234805.GB13573@kroah.com> <55935FC1.8090203@codeweavers.com>
 <20150701054416.GA23370@kroah.com> <55940D85.9030702@codeweavers.com>
 <20150701161342.GB31389@kroah.com> <559C0285.6090509@codeweavers.com>
Cc: spice-devel@lists.freedesktop.org, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org
From: Hans de Goede <hdegoede@redhat.com>
Message-ID: <559CCD39.90606@redhat.com>
Date: Wed, 8 Jul 2015 09:11:53 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.0.1
MIME-Version: 1.0
In-Reply-To: <559C0285.6090509@codeweavers.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2695
Lines: 64

Hi,

On 07-07-15 18:47, Jeremy White wrote:
>
>>>
>>> Well, the checkpatch.pl reports were all style (and mostly whitespace);
>>> roughly 3000 of them against 3000 lines of code :-/.  I did review the
>>> code, looking for areas where I thought it would badly cram into the
>>> kernel, and I adjusted the few I found (and sent changes upstream).
>>
>> style matters, as it's a thing with your brain.  You learn patterns and
>> if the patterns change, you have to do more work and don't see the real
>> issues involved.  So by ignoring our style you are saying you don't want
>> anyone else in the kernel community to ever review or work on the code,
>> which isn't ok.
>
> Looks like I can't side step this unless Hans is willing to shift the
> usbredir project entirely to using kernel style :-/.

I'm fine with moving the usbredir project to the kernel style, the question
is how to do this without causing any hidden breakage.

Can you create a gnu-indent invocation which will do most of the work?

And then a hopefully managable sized patch on top to fix the remaining
style errors in usbredirparser ?

> I will plan to make changes so that checkpatch runs clean; I lay out my
> concerns and my plan below to make sure I'm taking the best path.
>
> My main concern with changing the ~2,500 lines of code from the upstream
> usbredir project is that it will increase the odds that I will introduce
> errors, both initially, and again later as I review and attempt to relay
> patches from the upstream.
>
> To summarize the checkpatch reports:  the biggest issue is whitespace,
> which shouldn't be a problem; I should be able to automate that without
> error.  There are also a fair number of one offs; FSF address, space
> after '!', etc.  I hope to persuade Hans to take a few style only
> patches upstream to address those.  That leaves a pack of about 60 brace
> placement and line length issues.
>
> I will plan to manually change those prior to submission.  Any upstream
> changes that affect the same code will be manually corrected as well,
> prior to submission.
>
> Make sense?

Sounds good, note that as said I'm fine with moving over the usbredir(parser)
code to the kernel style, as long as the changes are reviewable.

I think it may be best to only convert the usbredirdparser files, as those
are the only ones you need for the kernel. Having a mixed style in usbredir
is not ideal, but something I can live with.

Regards,

Hans

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/