Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Fri, 7 Feb 2003 19:35:35 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Fri, 7 Feb 2003 19:35:35 -0500 Received: from mccammon.ucsd.edu ([132.239.16.211]:59293 "EHLO mccammon.ucsd.edu") by vger.kernel.org with ESMTP id ; Fri, 7 Feb 2003 19:35:35 -0500 Date: Fri, 7 Feb 2003 16:45:13 -0800 (PST) From: Alexei Podtelezhnikov X-X-Sender: apodtele@chemcca61.ucsd.edu To: john@grabjohn.com cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] 2.5.59 : sound/oss/vidc.c (CORRECTED) Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1296 Lines: 37 John Bradford (john@grabjohn.com) wrote: > 36 < hwrate < 3332 ^^^^^^ should be 'newsize' Yeap, and the following couple of lines: /* 36 < newsize 3332; rounding it off * to the nearest power of 2, no less than 256 */ for (new2size = 384; new2size < newsize; new2size <<= 1); new2size -= new2size / 3; safely replace the whole following block: if (newsize < 208) newsize = 208; if (newsize > 4096) newsize = 4096; for (new2size = 128; new2size < newsize; new2size <<= 1); if (new2size - newsize > newsize - (new2size >> 1)) new2size >>= 1; if (new2size > 4096) { printk(KERN_ERR "VIDC: error: dma buffer (%d) %d > 4K\n", newsize, new2size); new2size = 4096; } Would somebody test this? A. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/