Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934221AbbGHH5W (ORCPT ); Wed, 8 Jul 2015 03:57:22 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:43214 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934597AbbGHH4t (ORCPT ); Wed, 8 Jul 2015 03:56:49 -0400 Date: Wed, 8 Jul 2015 10:55:26 +0300 From: Dan Carpenter To: Robert Baldyga Cc: Robert Baldyga , devel@driverdev.osuosl.org, hamohammed.sa@gmail.com, chris@rorvick.com, tapaswenipathak@gmail.com, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, nicolas.ferre@atmel.com, hgujulan@visteon.com, balbi@ti.com, linux-kernel@vger.kernel.org, mina86@mina86.com, vinc94@gmail.com, roberta.dobrescu@gmail.com, andrzej.p@samsung.com, linux-arm-kernel@lists.infradead.org, m.szyprowski@samsung.com Subject: Re: [PATCH 1/5] usb: gadget: ffs: call functionfs_unbind() if _ffs_func_bind() fails Message-ID: <20150708075526.GK4341@mwanda> References: <1436277773-14274-1-git-send-email-r.baldyga@samsung.com> <1436277773-14274-2-git-send-email-r.baldyga@samsung.com> <20150707145345.GD4341@mwanda> <559BF79B.903@hackerion.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <559BF79B.903@hackerion.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 494 Lines: 15 On Tue, Jul 07, 2015 at 06:00:27PM +0200, Robert Baldyga wrote: > Decrement is done in ffs_func_unbind() which is not called in this > error path. Oh. Duh. I got functionfs_unbind() and ffs_func_unbind() mixed up. Sorry. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/