Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964943AbbGHIWC (ORCPT ); Wed, 8 Jul 2015 04:22:02 -0400 Received: from eusmtp01.atmel.com ([212.144.249.242]:9139 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933292AbbGHIVi (ORCPT ); Wed, 8 Jul 2015 04:21:38 -0400 Message-ID: <559CDD4A.2000609@atmel.com> Date: Wed, 8 Jul 2015 10:20:26 +0200 From: Nicolas Ferre Organization: atmel User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Robert Baldyga , , CC: , , , , , , , , , , , , Subject: Re: [PATCH 5/5] usb: gadget: atmel_usba_udc: add missing ret value check References: <1436277773-14274-1-git-send-email-r.baldyga@samsung.com> <1436277773-14274-6-git-send-email-r.baldyga@samsung.com> In-Reply-To: <1436277773-14274-6-git-send-email-r.baldyga@samsung.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.161.30.18] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1283 Lines: 40 Le 07/07/2015 16:02, Robert Baldyga a ?crit : > Add missing return value check. In case of error print debug message > and return error code. > > Signed-off-by: Robert Baldyga Yes, it's indeed missing: Acked-by: Nicolas Ferre Thanks, bye. > --- > drivers/usb/gadget/udc/atmel_usba_udc.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/drivers/usb/gadget/udc/atmel_usba_udc.c > index 4095cce0..37d414e 100644 > --- a/drivers/usb/gadget/udc/atmel_usba_udc.c > +++ b/drivers/usb/gadget/udc/atmel_usba_udc.c > @@ -1989,6 +1989,10 @@ static struct usba_ep * atmel_udc_of_init(struct platform_device *pdev, > ep->can_isoc = of_property_read_bool(pp, "atmel,can-isoc"); > > ret = of_property_read_string(pp, "name", &name); > + if (ret) { > + dev_err(&pdev->dev, "of_probe: name error(%d)\n", ret); > + goto err; > + } > ep->ep.name = name; > > ep->ep_regs = udc->regs + USBA_EPT_BASE(i); > -- Nicolas Ferre -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/