Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965069AbbGHIcL (ORCPT ); Wed, 8 Jul 2015 04:32:11 -0400 Received: from ipmail06.adl6.internode.on.net ([150.101.137.145]:3361 "EHLO ipmail06.adl6.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965060AbbGHIbc (ORCPT ); Wed, 8 Jul 2015 04:31:32 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A2DcDACh3pxVXWZJAg5bFoJ8VGCDILxMhXcCgU1NAQEBAQEBB0RAQQWDXgEBAwEjBBEeIgEFCwgDGgIFFgsCAgkDAgECAScKFAYNAQcCiCIHDrYTlkcBAQEBAQUBAQEBHoEhiiqFBgeCaIFDAQSNDIQsgmWaA4pShDEuMQEBAYJIAQEB Message-ID: <559CDFE1.7060503@internode.on.net> Date: Wed, 08 Jul 2015 18:01:29 +0930 From: Arthur Marsh User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Icedove/31.7.0 MIME-Version: 1.0 To: Peter Zijlstra CC: Mathieu Desnoyers , linux-kernel@vger.kernel.org, Rusty Russell , rostedt , Oleg Nesterov , "Paul E. McKenney" Subject: Re: lock-up with module: Optimize __module_address() using a latched RB-tree References: <55997889.5020101@internode.on.net> <20150706100447.GX3644@twins.programming.kicks-ass.net> <559A545A.80508@internode.on.net> <20150706103246.GY3644@twins.programming.kicks-ass.net> <559B63A2.4030601@internode.on.net> <20150707072951.GM3644@twins.programming.kicks-ass.net> <1736781680.1883.1436286785932.JavaMail.zimbra@efficios.com> <559C3371.2030704@internode.on.net> <20150707215620.GM19282@twins.programming.kicks-ass.net> <20150707221122.GU18673@twins.programming.kicks-ass.net> In-Reply-To: <20150707221122.GU18673@twins.programming.kicks-ass.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1380 Lines: 43 Peter Zijlstra wrote on 08/07/15 07:41: > On Tue, Jul 07, 2015 at 11:56:20PM +0200, Peter Zijlstra wrote: > Could you try the below? It appears there was a spot freeing modules > that forgot to take them out of the tree. > > If that fails, try and disable CONFIG_MODULE_UNLOAD. I tried the patch below, re-built and installed and booted the kernel and saw: http://www.users.on.net/~arthur.marsh/20150708471.jpg http://www.users.on.net/~arthur.marsh/20150708472.jpg I'm now rebuilding the kernel with CONFIG_MODULE_UNLOAD disabled. Arthur. > > --- > kernel/module.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/kernel/module.c b/kernel/module.c > index 3e0e19763d24..4d2b82e610e2 100644 > --- a/kernel/module.c > +++ b/kernel/module.c > @@ -3557,6 +3557,7 @@ static int load_module(struct load_info *info, const char __user *uargs, > mutex_lock(&module_mutex); > /* Unlink carefully: kallsyms could be walking list. */ > list_del_rcu(&mod->list); > + mod_tree_remove(mod); > wake_up_all(&module_wq); > /* Wait for RCU-sched synchronizing before releasing mod->list. */ > synchronize_sched(); > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/