Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934793AbbGHIjP (ORCPT ); Wed, 8 Jul 2015 04:39:15 -0400 Received: from filtteri5.pp.htv.fi ([213.243.153.188]:41201 "EHLO filtteri5.pp.htv.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932709AbbGHIjB (ORCPT ); Wed, 8 Jul 2015 04:39:01 -0400 Date: Wed, 8 Jul 2015 11:38:49 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: "Luis R. Rodriguez" Cc: Borislav Petkov , Andrew Morton , Ingo Molnar , Ville =?iso-8859-1?Q?Syrj=E4l=E4?= , Andy Lutomirski , Tomi Valkeinen , "Michael S. Tsirkin" , Benjamin Herrenschmidt , "linux-kernel@vger.kernel.org" , linux-fbdev , "linux-pci@vger.kernel.org" , Dave Airlie , Toshi Kani , Suresh Siddha , Linus Torvalds , Thomas Gleixner , Juergen Gross , Daniel Vetter , Antonino Daplas , Jean-Christophe Plagniol-Villard , Rob Clark , Mathias Krause , Andrzej Hajda , Mel Gorman , Vlastimil Babka , Davidlohr Bueso Subject: Re: [PATCH v5 1/3] video: fbdev: atyfb: clarify ioremap() base and length used Message-ID: <20150708083849.GB13710@sci.fi> Mail-Followup-To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= , "Luis R. Rodriguez" , Borislav Petkov , Andrew Morton , Ingo Molnar , Ville =?iso-8859-1?Q?Syrj=E4l=E4?= , Andy Lutomirski , Tomi Valkeinen , "Michael S. Tsirkin" , Benjamin Herrenschmidt , "linux-kernel@vger.kernel.org" , linux-fbdev , "linux-pci@vger.kernel.org" , Dave Airlie , Toshi Kani , Suresh Siddha , Linus Torvalds , Thomas Gleixner , Juergen Gross , Daniel Vetter , Antonino Daplas , Jean-Christophe Plagniol-Villard , Rob Clark , Mathias Krause , Andrzej Hajda , Mel Gorman , Vlastimil Babka , Davidlohr Bueso References: <1435196060-27350-1-git-send-email-mcgrof@do-not-panic.com> <1435196060-27350-2-git-send-email-mcgrof@do-not-panic.com> <20150625230437.GA4362@sci.fi> <20150625231103.GB4362@sci.fi> <20150626010927.GI3005@wotan.suse.de> <20150626073028.GA14776@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2221 Lines: 62 On Tue, Jul 07, 2015 at 05:24:57PM -0700, Luis R. Rodriguez wrote: > On Thu, Jul 2, 2015 at 4:23 PM, Luis R. Rodriguez wrote: > > On Fri, Jun 26, 2015 at 12:30 AM, Borislav Petkov wrote: > >> On Fri, Jun 26, 2015 at 03:09:27AM +0200, Luis R. Rodriguez wrote: > >>> Sure, mind this as a follow up patch if its too late? > >> > >> No need, you can send me an updated one - I'll replace it. > > > > Will do! > > OK the commend I'm adding: > > @@ -3489,6 +3489,15 @@ static int atyfb_setup_generic(struct pci_dev > *pdev, struct fb_info *info, > > /* Map in frame buffer */ > info->fix.smem_start = addr; > + > + /* > + * The framebuffer is not always 8 MiB that's just the size of the > + * PCI BAR, this is later corrected for use with write-combining > + * helpers with aty_fudge_framebuffer_len() which will adjust the > + * framebuffer accordingly depending on the device. That somehow gives me the impression that aty_fudge_framebuffer_len() changes smem_len to match the framebuffer size, which it does not. Dunno, maybe something like this? /* * The framebuffer is not always 8 MiB that's just the size of the * PCI BAR. We temporarily abuse smem_len here to store the size * of the BAR. aty_init() will later correct it to match the actual * framebuffer size. * * On devices that don't have the auxiliary register aperture, the * registers are housed at the top end of the framebuffer PCI BAR. * aty_fudge_framebuffer_len() is used to reduce smem_len to not * overlap with the registers. */ > We do this > + * to match semantics over ioremap calls on framebuffer devices > + * with with other drivers with the info->fix.smem_len. > + */ > info->fix.smem_len = 0x800000; > > info->screen_base = ioremap(info->fix.smem_start, info->fix.smem_len); > > Will respin. > > Luis -- Ville Syrj?l? syrjala@sci.fi http://www.sci.fi/~syrjala/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/